feat(api-service): Nv 5304 update pricing and billing pages #7718
+1,570
−657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for dashboard-v2-novu-staging failed. Why did it fail? →
|
❌ Deploy Preview for dev-web-novu failed. Why did it fail? →
|
fix(dashboard): added FF to FE fix(dashboard): added FF to FE fix(dashboard): change default sorting fix(api-service): compiles68457b4c79403ba223d4f360925eb0422e33dffb fix(api-service): compiles68457b4c79403ba223d4f360925eb0422e33dffb fix(api-service): compiles
tatarco
force-pushed
the
nv-5304-update-pricing-and-billing-pages
branch
from
e764002 to
ea985f6
Compare
tatarco
changed the title
ChmaraX
requested changes
Feb 13, 2025
There was a problem hiding this comment.
Please fix the spellcheck errors as well.
Also, we need to change this dashboard part as well:
https://github.com/novuhq/novu/blob/bfb8b9517dd4d8342c0f9850974fb226882ec10c/apps/web/src/ee/billing/components/PlanActionButton.tsx
The action button to "Upgrade plan" has a hardcoded http call like this:
...
api.post(checkoutUrl, {
billingInterval: selectedBillingInterval,
apiServiceLevel: ApiServiceLevelEnum.BUSINESS,
}),
...The apiServiceLevel on the button need to change dynamically based on selected plan.
| @@ -158,7 +156,7 @@ describe('webhook event - checkout.session.completed #novu-v2', () => { | |||
| throw new Error('ee-billing does not exist'); | |||
| } | |||
|
|
|||
| const { CheckoutSessionCompletedHandler, VerifyCustomer, GetPrices } = eeBilling; | |||
| const { CheckoutSessionCompletedHandler, VerifyCustomer, GetStripePlanPriceUseCase } = eeBilling; | |||
There was a problem hiding this comment.
this usecase is not renamed in EE PR - please use GetPrices
|
|
||
| describe('CreateSubscription #novu-v2', () => { | ||
| const eeBilling = require('@novu/ee-billing'); | ||
| if (!eeBilling) { | ||
| throw new Error('ee-billing does not exist'); | ||
| } | ||
|
|
||
| const { CreateSubscription, GetPrices, UpdateServiceLevel, CreateSubscriptionCommand } = eeBilling; | ||
| const { CreateSubscription, GetStripePlanPriceUseCase, UpdateServiceLevel, CreateSubscriptionCommand } = eeBilling; |
There was a problem hiding this comment.
this usecase is not renamed in EE PR - please use GetPrices
| @@ -6,6 +6,7 @@ import { encryptApiKey } from '@novu/application-generic'; | |||
| import { EnvironmentRepository, NotificationGroupRepository } from '@novu/dal'; | |||
|
|
|||
| import { EnvironmentEnum, PROTECTED_ENVIRONMENTS } from '@novu/shared'; | |||
| import { undefined } from 'zod'; | |||
| import { TierExceededException } from './tier-exceeded.exception'; | ||
|
|
||
| @Injectable() | ||
| export class ValidateTiersUseCase { |
There was a problem hiding this comment.
I'm wondering if this should be placed in the create-environment module since tier limits are not specific to environments only.
Comment on lines
+24
to
+30
| protected mapEntity<TData>(data: TData): TData extends null ? null : OrganizationEntity { | ||
| const mapEntity = super.mapEntity(data); | ||
|
|
||
| return mapEntity; | ||
| // return { ...mapEntity, apiServiceLevel: migrateServiceLevel(mapEntity?.apiServiceLevel) }; | ||
| } | ||
|
|
There was a problem hiding this comment.
Please remove this since it does exactly the same thing as super.mapEntity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer