fix(dashboard): change default sorting #7713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SokratisVidros
approved these changes
Feb 12, 2025
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LetItRock
requested changes
Feb 12, 2025
| @@ -45,7 +45,7 @@ export const WorkflowsPage = () => { | |||
| const navigate = useNavigate(); | |||
| const [searchParams, setSearchParams] = useSearchParams({ | |||
| orderDirection: DirectionEnum.DESC, | |||
| orderBy: 'updatedAt', | |||
| orderBy: 'createdAt', | |||
There was a problem hiding this comment.
The thing is that we don't show the createdAt column, so this might result in a situation where users won't be able to sort back by the createdAt.
cc @SokratisVidros
There was a problem hiding this comment.
so we should probably introduce the createdAt column
There was a problem hiding this comment.
I don't think it's necessary. Sorting should be deterministic for now. We should be good.
SokratisVidros
deleted the
nv-5375-change-default-sort-to-created-at-in-workflows-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer