feat(dashboard): step conditions analytics #7684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LetItRock
requested review from
SokratisVidros,
scopsy,
BiswaViraj,
ChmaraX,
tatarco,
djabarovgeorge and
desiprisg
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LetItRock
commented
Feb 7, 2025
Comment on lines
+132
to
+133
| const uniqueFieldTypes: string[] = getUniqueFieldNamespaces(skip); | ||
| const uniqueOperators: string[] = getUniqueOperators(skip); |
There was a problem hiding this comment.
calculate unique field namespaces and operators used
| stepType: step.type, | ||
| fieldTypes: uniqueFieldTypes, | ||
| operators: uniqueOperators, | ||
| type: newConditionsCount < oldConditionsCount ? 'deletion' : 'update', |
There was a problem hiding this comment.
determine whether conditions were removed or updated
Comment on lines
+18
to
+24
| export const countConditions = (jsonLogic?: RQBJsonLogic) => { | ||
| if (!jsonLogic) return 0; | ||
|
|
||
| const query = parseJsonLogic(jsonLogic); | ||
|
|
||
| return countRules(query); | ||
| }; |
There was a problem hiding this comment.
moved from the useConditionsCount hook
Comment on lines
+46
to
+52
| export const getUniqueFieldNamespaces = (jsonLogic?: RQBJsonLogic): string[] => { | ||
| if (!jsonLogic) return []; | ||
|
|
||
| const query = parseJsonLogic(jsonLogic); | ||
|
|
||
| return recursiveGetUniqueFields(query); | ||
| }; |
There was a problem hiding this comment.
helper to calculate unique field namespaces
| return Array.from(operators); | ||
| } | ||
|
|
||
| export const getUniqueOperators = (jsonLogic?: RQBJsonLogic): string[] => { |
There was a problem hiding this comment.
helper to calculate unique operators
scopsy
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Step Conditions Analytics
Screenshots
Screen.Recording.2025-02-07.at.14.03.45.mov