fix: tests #5436
Merged
fix: tests #5436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
BiswaViraj
force-pushed
the
fix-web-tests
branch
from
477ece9 to
7d5cd89
Compare
BiswaViraj
commented
Apr 19, 2024
| @@ -62,6 +72,7 @@ export const StepEditorSidebar = ({ children }: { children: ReactNode }) => { | |||
| navigate(basePath); | |||
| }} | |||
| data-test-id="step-editor-sidebar" | |||
| onSubmit={handleSubmit(onSubmitHandler, onInvalid)} | |||
There was a problem hiding this comment.
Due to this, it was not submitting the form on the editor and hence the tests were failing on update workflow
antonjoel82
approved these changes
Apr 19, 2024
| @@ -1,5 +1,6 @@ | |||
| describe('Organization Page', function () { | |||
| beforeEach(function () { | |||
| cy.mockFeatureFlags({ IS_INFORMATION_ARCHITECTURE_ENABLED: true }); | |||
There was a problem hiding this comment.
👏 praise: Good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer