Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nx circular dependencies #4958

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Fix nx circular dependencies #4958

merged 2 commits into from
Dec 8, 2023

Conversation

davidsoderberg
Copy link
Contributor

image

@davidsoderberg davidsoderberg changed the base branch from next to translation-management December 8, 2023 08:52
BiswaViraj
BiswaViraj approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@BiswaViraj BiswaViraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

apps/api/src/app.module.ts Outdated Show resolved Hide resolved
@davidsoderberg davidsoderberg merged commit 80fce49 into translation-management Dec 8, 2023
19 of 23 checks passed
@davidsoderberg davidsoderberg deleted the fix-nx-circular-dependencies branch December 8, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BiswaViraj BiswaViraj BiswaViraj approved these changes

@ainouzgali ainouzgali Awaiting requested review from ainouzgali

Assignees
No one assigned
Labels
@novu/api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidsoderberg @BiswaViraj