Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(web): Fix add tenant button location #4935

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Conversation

nick2432
Copy link
Contributor

@nick2432 nick2432 commented Dec 4, 2023

What change does this PR introduce?

I modified the container padding from 0px 30px 8px 30px to 0px 24px 0px 24px.
Screenshot from 2023-12-04 09-20-19

Why was this change needed?

Closes #4886

Other information (Screenshots)

Screenshot from 2023-12-04 08-58-17

@scopsy scopsy changed the title fix: addbutton style(web): Fix add tenant button location Dec 4, 2023
@scopsy
Copy link
Contributor

scopsy commented Dec 5, 2023

Thank you!

@scopsy scopsy merged commit b1d06cd into novuhq:next Dec 5, 2023
@SebastianStehle
Copy link

I would also check the other buttons, I have seen other, minor differences. But I am not 100% sure anymore.

@nick2432
Copy link
Contributor Author

nick2432 commented Dec 5, 2023

I would also check the other buttons, I have seen other, minor differences. But I am not 100% sure anymore.
@scopsy
can you tell me which one button location is correct
if first one is correct then we have to change the Integrations Store button position else we have to change workflow and tenant button position
1.....Screenshot from 2023-12-05 16-59-32

2......Screenshot from 2023-12-05 16-58-49
i think second one is correct

@scopsy
Copy link
Contributor

scopsy commented Dec 5, 2023

Option number 1 is the correct one 🙏

@nick2432
Copy link
Contributor Author

nick2432 commented Dec 5, 2023

Option number 1 is the correct one 🙏

can i raise issue for integration store button position?

@scopsy
Copy link
Contributor

scopsy commented Dec 5, 2023

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: tenant add button is not always in the same location
4 participants