feat(app-gen, worker): Add MetricsService #4928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rifont
changed the title
rifont
commented
Dec 2, 2023
| webSocketsQueueService = moduleRef.get<WebSocketsQueueService>(WebSocketsQueueService); | ||
| workflowQueueService = moduleRef.get<WorkflowQueueService>(WorkflowQueueService); | ||
| }); | ||
|
|
There was a problem hiding this comment.
This wasn't being used, it's overridden below.
| nr.recordMetric(`Queue/${deploymentName}/${queueService.topic}/delayed`, delayedCount); | ||
| nr.recordMetric(`Queue/${deploymentName}/${queueService.topic}/active`, activeCount); | ||
|
|
||
| Logger.verbose(`Queue/${deploymentName}/${queueService.topic}`, { waitCount, delayedCount, activeCount }); |
There was a problem hiding this comment.
Verbose logging is handled in the metrics service now.
| "@types/sinon": "^9.0.0", | ||
| "codecov": "^3.5.0", | ||
| "cpx": "^1.5.0", | ||
| "dotenv": "^8.2.0", | ||
| "chai": "^4.2.0", | ||
| "jest": "^27.1.0", | ||
| "newrelic": "^9", | ||
| "npm-run-all": "^4.1.5", |
There was a problem hiding this comment.
Adding newrelic as devDependecies to keep the peer deps working as normal.
scopsy
approved these changes
Dec 2, 2023
Comment on lines
+152
to
+163
| describe('Azure', () => { | ||
| it('should contain AzureMetricsService if METRICS_SERVICE is set to AZURE', async () => { | ||
| process.env.METRICS_SERVICE = 'AZURE'; | ||
| const metricsServices = await createServices(); | ||
|
|
||
| expect( | ||
| metricsServices.some( | ||
| (metricsService) => metricsService instanceof AzureMetricsService | ||
| ) | ||
| ).toBe(true); | ||
| delete process.env.METRICS_SERVICE; | ||
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Why was this change needed?
By providing a capability to send metrics to any cloud monitoring tools, we can support self-hosted customers to use metrics tools of their choice and standardize metrics gathering on the Novu platform. Additionally, application-level metrics can be used as auto-scaling indicators.
Other information (Screenshots)
Startup logs info
Queue Metrics on Cloudwatch (verified locally with AWS Creds)
Queue Metrics on NewRelic (verified locally with NR Creds)
