nope-ip removal - Phase 1 #8714
Open
+27
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nope-ip removal - Phase 1 # `net_utils` - Will no longer use the deprecated `url.parse()` and use `new URL()` instead. It is possible because we use it with .hostname, which is equal for both. - Create ip_toLong to replace the node-ip toLong # Others - Replace the use of isV4Format to net.isIPv4 - Replace the use of isV6Format to net.isIPv6 - Calling ip_toLong instead of toLong Signed-off-by: liranmauda <[email protected]>
jackyalbo
reviewed
Jan 30, 2025
| @@ -578,10 +577,10 @@ function _prepare_auth_request(req) { | |||
| const client_ip = net_utils.unwrap_ipv6(req.auth.client_ip); | |||
| if (client_ip) { | |||
| let is_allowed = false; | |||
| const client_ip_val = ip_module.toLong(client_ip); | |||
| const client_ip_val = net_utils.ip_toLong(client_ip); | |||
There was a problem hiding this comment.
I'm not sure if we still need allowed_ips in accounts. maybe we should get rid of that? then we don't need most of the code here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nope-ip removal - Phase 1
net_utilsurl.parse()and usenew URL()instead. It is possible because we use it with .hostname, which is equal for both.Others
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: