Skip to content

Commit

Permalink
Added one more TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
beveradb committed Nov 17, 2023
1 parent 50e1740 commit 329f138
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion lyrics_transcriber/transcriber.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,9 +203,11 @@ def write_corrected_lyrics_data_file(self):
# TODO: Add some additional filtering and cleanup of whisper results before sending to LLM,
# e.g. remove segments with low confidence, remove segments with no words, maybe.

# TODO: Add more to the LLM instructions (or consider post-processing cleanup) to get rid of overlapping words
# TODO: Add more to the LLM instructions (or consider post-processing cleanup) to get rid of overlapping segments
# when there are background vocals or other overlapping lyrics

# TODO: Test if results are cleaner when using the vocal file from a background vocal audio separation model

for segment in self.whisper_result_dict["segments"]:
simplified_segment = {
"id": segment["id"],
Expand Down

0 comments on commit 329f138

Please sign in to comment.