adding a x/y getter, useful for plume #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -245,7 +245,9 @@ where | |||
| } | |||
| } | |||
|
|
|||
| trait BigCurveTrait { | |||
| pub trait BigCurveTrait<BigNum> { | |||
There was a problem hiding this comment.
I'm reluctant to introduce a generic here, just to support this.
The BigCurve struct already has pub members x and y. Why couldn't you access those, sorry?
|
I'm also leery of adding a generic to the trait. In general when making significant changes to libraries, I'd like to see a bit more context about the problem you're solving and why this would be useful. Whenever we add more stuff to the library interface that's more stuff that we need to maintain going forwards so it needs to be justified. |
|
I'm going to politely close this one, to clear up my notifications :) Thanks for continuing to try to improve things! Keep it up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding two getters for
xandy, most likely could have done without them but thought it would be easy enough this way