chore: Rename StructDefinition to TypeDefinition
#7614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
asterite
approved these changes
Mar 7, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 763df5a | Previous: ba5beb6 | Ratio |
|---|---|---|---|
noir-lang_noir_bigcurve_ |
266 s |
220 s |
1.21 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
|
🚀 Deployed on https://67cb2ad294bf9fef87674374--noir-docs.netlify.app |
|
FYI @noir-lang/developerrelations on Noir doc changes. |
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Mar 8, 2025
feat: add optional oracle resolver url in `acvm_cli` (noir-lang/noir#7630) chore: Rename `StructDefinition` to `TypeDefinition` (noir-lang/noir#7614) fix: Error on infinitely recursive types (noir-lang/noir#7579) fix: update error message to display 128 bits as valid bit size (noir-lang/noir#7626) chore: update docs to reflect u128 type (noir-lang/noir#7623) feat: array concat method (noir-lang/noir#7199)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #7416
Summary*
Renames
StructDefinitiontoTypeDefinitionand renamesType::as_structtoType::as_data_typefor lack of a better name.StructDefinitionstill works but will produce a deprecated warningType::as_structsimilarly still works and callsType::as_data_type, also producing a deprecated warning.Due to the above, this PR is non-breaking. Eventually we'll still probably want breaking type changes though. Namely any function to retrieve the struct fields from a
TypeDefinitionshould be changed to return aOptionof the previous return type since it may be called with an enum now.Additional Context
Compared to separating
StructDefinitionfromEnumDefinitionI think this way is more convenient since it allows users to define one attribute function to work on all data types, instead of requiring a separate function to handle structs & enums. The later would also necessitate we needed a separatestruct_deriveandenum_derive, etc.Documentation*
Check one:
PR Checklist*
cargo fmton default settings.