chore: replace action with reusable workflows #7282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakoshh
reviewed
Feb 11, 2025
| token: ${{ secrets.NOIR_REPO_TOKEN }} | ||
| # Omitting a tag results in a nightly | ||
| inputs: "{ \"publish\": true }" | ||
| public-nargo: |
There was a problem hiding this comment.
Suggested change
| public-nargo: | |
| publish-nargo: |
aakoshh
reviewed
Feb 11, 2025
| workflow: publish-es-packages.yml | ||
| token: ${{ secrets.NOIR_REPO_TOKEN }} | ||
| inputs: "{ \"noir-ref\": \"${{ env.GITHUB_REF }}\", \"npm-tag\": \"nightly\" }" | ||
| public-js-packages: |
There was a problem hiding this comment.
Suggested change
| public-js-packages: | |
| publish-js-packages: |
aakoshh
reviewed
Feb 11, 2025
| ref: master | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| inputs: '{ "tag": "${{ needs.release-please.outputs.tag-name }}", "publish": true }' | ||
| uses: noir-lang/noir/.github/workflows/publish-nargo.yml@master |
There was a problem hiding this comment.
Why is this pinned to master?
There was a problem hiding this comment.
I might be misunderstanding it: it looks like the release workflow only runs on master, and while previously we dispatched via the API, which required to tell which branch to run the publish workflow on, now we call it inside the workflow, so it will run on the same branch as the release workflow itself.
With @master, would it just pull the workflow definition from master and apply it to whatever branch this workflow is running on, or would master apply to the jobs in the publish-nargo.yml workflow itself?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.