Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): Parse match expressions #7243

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Jan 30, 2025

Description

Problem*

Working towards #988

Summary*

Add parser, formatter, lsp support for match expressions

Additional Context

Still can't use these in a program, we panic in the monomorphizer for them. Just pushing these somewhat trivial changes before the chunkier changes of compiling match expressions to a decision tree, checking for completeness, redundancy, then monomorphizing etc.

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher requested a review from a team January 30, 2025 19:54
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 4d07680 Previous: 0c6c637 Ratio
noir-lang_noir_string_search_ 1 s 0 s +∞
noir-lang_mimc_ 1 s 0 s +∞
noir-lang_eddsa_ 2 s 1 s 2
AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob 61 s 49 s 1.24

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@jfecher
Copy link
Contributor Author

jfecher commented Jan 31, 2025

(ready for review now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant