feat: add array range and reverse functions #7159
Conversation
|
Thank you for your contribution to the Noir language. Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch. Thanks for your understanding. |
| /// assert(arr == [0, 1, 2, 3, 4]); | ||
| /// } | ||
| /// ``` | ||
| pub fn range<T>(size: Field) -> [Field] { |
There was a problem hiding this comment.
The T generic parameter is not used, and technically this returns a slice, rather than an array.
size is usually expressed as u32.
Returning Field seems a bit specific; the library so far is completely generic.
Perhaps something like std::array::from_fn would be a more flexible alternative to make an actual array of a given size, with content created for each index given to a lambda as u32 between 0 and N. You could use it to cast to Field, or map it to a range other than 0..N, e.g. by an offset.
Description:
This PR adds two utility functions to the array module:
range(size: Field)- creates an array of numbers from 0 to size-1reverse()- returns a new array with elements in reverse orderResolves TODO comments from test_programs/noir_test_success/brillig_oracle/src/main.nr
Both functions are fully tested and documented with examples.