Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename StructDefinition to TypeDefinition #7416

Closed
TomAFrench opened this issue Feb 18, 2025 · 0 comments · Fixed by #7614
Closed

Rename StructDefinition to TypeDefinition #7416

TomAFrench opened this issue Feb 18, 2025 · 0 comments · Fixed by #7614
Assignees
@jfecher
Milestone
1.0

Comments

@TomAFrench
Copy link
Member

From: https://docs.google.com/document/d/1FkzUI8Oawcg2CaQtf58gbkrdjj1083GwPE5YHJvMtUg/edit?usp=sharing

Should we refactor StructDefinition into TypeDefinition for the enum changes like we did internally in the compiler as well? We could just add a separate EnumDefinition although they would have some duplicated functions for the type’s name, generics, etc
@TomAFrench TomAFrench added this to the 1.0 milestone Feb 18, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Feb 18, 2025
@jfecher jfecher mentioned this issue Mar 6, 2025
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfecher jfecher

Labels
None yet
Projects
Noir
Status: ✅ Done
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

chore: Rename StructDefinition to TypeDefinition noir-lang/noir
2 participants
@jfecher @TomAFrench