Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect implementation of fail function #36

Closed
wants to merge 1 commit into from

Conversation

Anon-im
Copy link

@Anon-im Anon-im commented Dec 27, 2024

Description

In the current implementation, the fail function calls itself without a termination condition, leading to infinite recursion. Instead of invoking the fail function from the parent DSTest contract, the current implementation loops on itself, making it impossible to properly execute tests and handle errors.

Problem*

Resolves

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@Anon-im
Copy link
Author

Anon-im commented Dec 27, 2024

@critesjosh Transfered PR to the foundry repo as requested! Thanks!

@Anon-im Anon-im changed the title Fix incorrect implementation of fail function Fix incorrect implementation of fail function Dec 27, 2024
@critesjosh critesjosh closed this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants