Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version script #23

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Add version script #23

merged 3 commits into from
Oct 24, 2024

Conversation

jzaki
Copy link
Contributor

@jzaki jzaki commented Oct 10, 2024

Description

Problem*

Easily check which version each example is.

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jzaki jzaki force-pushed the jz/add-version-script branch from 2d8c84d to e9740da Compare October 24, 2024 09:29
@jzaki
Copy link
Contributor Author

jzaki commented Oct 24, 2024

Key points here:

  • add name to module on creation with nargo/cargo new
  • additional helper script to print compiler versions from nargo/cargo .toml files

@jzaki jzaki requested review from saleel and critesjosh October 24, 2024 09:41
@jzaki jzaki merged commit 9db1477 into master Oct 24, 2024
2 checks passed
@jzaki jzaki deleted the jz/add-version-script branch October 24, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleel saleel saleel left review comments

@signorecello signorecello Awaiting requested review from signorecello

@catmcgee catmcgee Awaiting requested review from catmcgee

@critesjosh critesjosh Awaiting requested review from critesjosh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzaki @saleel