Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DON'T MERGE : Updating to 0.23.0 #14

Merged
merged 8 commits into from
Feb 12, 2024
Merged

DON'T MERGE : Updating to 0.23.0 #14

merged 8 commits into from
Feb 12, 2024

Conversation

signorecello
Copy link
Contributor

@signorecello signorecello commented Feb 7, 2024 •
edited
Loading

Quite some iteration here. Summary of changes:

  • Updated the recursion interface needed for 0.23.0
  • Updated the rest of noir packages to 0.23.0 (i.e. noir_wasm)
  • Removed most of the code to start using React hooks, as we should've done long time ago
  • Updated hardhat to be TS+ESM ♥️ And the whole app to be ESM
  • Ditched ethers in favour of viem, and started using Wagmi hooks
  • Removed dummy support for other chains: this is outside of the scope of a simple example
  • Made the app run just fine if the user has no wallet installed
  • Removed redundant non-recursive test

Closes AztecProtocol/dev-rel#163

@socket-security Socket Security
Copy link

socket-security bot commented Feb 7, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@adraffy/[email protected] None 0 441 kB adraffy
npm/@aztec/[email protected] None 0 29.7 MB charlielye
npm/@fastify/[email protected] None 0 80.1 kB eomm
npm/@isaacs/[email protected] None +7 184 kB isaacs
npm/@next/[email protected] environment, filesystem 0 11.7 kB vercel-release-bot
npm/@next/[email protected] None 0 106 MB vercel-release-bot
npm/@next/[email protected] None 0 105 MB vercel-release-bot
npm/@next/[email protected] None 0 108 MB vercel-release-bot
npm/@next/[email protected] None 0 132 MB vercel-release-bot
npm/@next/[email protected] None 0 120 MB vercel-release-bot
npm/@next/[email protected] None 0 144 MB vercel-release-bot
npm/@next/[email protected] None 0 95.3 MB vercel-release-bot
npm/@next/[email protected] None 0 87.2 MB vercel-release-bot
npm/@next/[email protected] None 0 123 MB vercel-release-bot
npm/@noir-lang/[email protected] None 0 6.47 MB noir-lang
npm/@noir-lang/[email protected] None +4 31.4 MB noir-lang
npm/@noir-lang/[email protected] None +3 7.42 MB noir-lang
npm/@noir-lang/[email protected] None +1 29 MB noir-lang
npm/@noir-lang/[email protected] None 0 876 kB noir-lang
npm/@noir-lang/[email protected] None +1 924 kB noir-lang
npm/@nomicfoundation/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +50 30.1 MB fvictorio
npm/@nomicfoundation/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +44 28.3 MB fvictorio
npm/@nomicfoundation/[email protected] environment Transitive: eval, filesystem, network, shell, unsafe +81 142 MB fvictorio
npm/@nomicfoundation/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +43 28.5 MB alcuadrado, fvictorio, nomic-foundation-publisher
npm/@nomicfoundation/[email protected] filesystem Transitive: environment, eval, network, shell, unsafe +46 128 MB fvictorio
npm/@npmcli/[email protected] Transitive: network +7 571 kB fritzy, gar, lukekarrys, ...2 more
npm/@npmcli/[email protected] filesystem 0 26.5 kB lukekarrys
npm/@pkgjs/[email protected] None 0 74.2 kB oss-bot
npm/@typechain/[email protected] filesystem +1 218 kB ethereum-ts-bot
npm/@typechain/[email protected] filesystem Transitive: environment, eval, network, shell, unsafe +46 28.4 MB ethereum-ts-bot
npm/@types/[email protected] None 0 76.8 kB types
npm/@types/[email protected] None 0 95.6 kB types
npm/@types/[email protected] None +1 4.07 MB types
npm/@types/[email protected] None +2 4.08 MB types
npm/@types/[email protected] None 0 6.16 kB types
npm/@types/[email protected] None 0 6.39 kB types
npm/@types/[email protected] None +3 1.68 MB types
npm/@types/[email protected] None 0 8.25 kB types
npm/@types/[email protected] None +2 4.08 MB types
npm/@types/[email protected] None +2 4.09 MB types
npm/[email protected] unsafe 0 479 kB vweevers
npm/[email protected] None 0 52.4 kB marijn
npm/[email protected] None 0 7.68 kB nexdrew
npm/[email protected] None 0 17.5 kB sindresorhus
npm/[email protected] filesystem 0 2.94 MB burt_harris
npm/[email protected] network +1 1.87 MB jasonsaayman
npm/[email protected] None +4 147 kB sindresorhus
npm/[email protected] filesystem Transitive: environment, shell +30 2.77 MB npm-cli-ops
npm/[email protected] Transitive: eval +8 189 kB ljharb
npm/[email protected] None 0 1.96 MB caniuse-lite
npm/[email protected] None +1 789 kB chaijs
npm/[email protected] None +3 836 kB keithamus
npm/[email protected] filesystem 0 5.75 kB isaacs
npm/[email protected] filesystem, unsafe Transitive: environment +2 6.25 MB vweevers
npm/[email protected] None 0 6.14 kB sindresorhus
npm/[email protected] None 0 1.25 MB faddee
npm/[email protected] None 0 54 kB chaijs
npm/[email protected] Transitive: eval +6 148 kB ljharb
npm/[email protected] environment, filesystem 0 76 kB motdotla
npm/[email protected] None 0 13.6 kB komagata
npm/[email protected] None 0 97.9 kB google-wombot
npm/[email protected] None +1 356 kB andris
npm/[email protected] None 0 12.3 kB achingbrain
npm/[email protected] None 0 12.3 kB ljharb
npm/[email protected] filesystem 0 11.6 kB lukeed
npm/[email protected] None 0 37.3 kB sssayegh
npm/[email protected] filesystem +1 139 kB mrmlnc
npm/[email protected] None 0 41.9 kB matteo.collina
npm/[email protected] None 0 773 kB 101arrowz
npm/[email protected] network 0 29.4 kB rubenverborgh
npm/[email protected] shell 0 60.4 kB isaacs
npm/[email protected] filesystem +1 299 kB npm-cli-ops
npm/[email protected] eval +4 107 kB ljharb
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +58 33.5 MB cgewecke
npm/[email protected] environment, filesystem, network, shell Transitive: eval, unsafe +42 28.2 MB fvictorio
npm/[email protected] Transitive: eval +5 118 kB ljharb
npm/[email protected] None 0 10.8 kB ljharb
npm/[email protected] None +1 42.6 kB ljharb
npm/[email protected] None 0 35.9 kB kornel
npm/[email protected] network 0 24.3 kB tootallnate
npm/[email protected] None 0 51.5 kB kael
npm/[email protected] None 0 679 kB leebyron
npm/[email protected] None 0 11.9 kB jensyt
npm/[email protected] None 0 13.6 kB indutny
npm/[email protected] None +3 83.6 kB ljharb
npm/[email protected] None 0 2.94 kB watson
npm/[email protected] None 0 4.04 kB heineiuo
npm/[email protected] environment +9 512 kB isaacs
npm/[email protected] None 0 210 kB vscode-bot
npm/[email protected] Transitive: environment, filesystem, unsafe +3 6.33 MB ralphtheninja, rvagg, vweevers
npm/[email protected] network Transitive: environment, filesystem, shell +48 4.02 MB npm-cli-ops
npm/[email protected] None +1 290 kB isaacs
npm/[email protected] environment, network +5 828 kB npm-cli-ops
npm/[email protected] None +1 51.9 kB isaacs
npm/[email protected] None 0 7 kB isaacs
npm/[email protected] None 0 124 kB isaacs
npm/[email protected] None 0 285 kB isaacs
npm/[email protected] None 0 17.3 kB isaacs
npm/[email protected] environment, eval, filesystem +1 2.1 MB joshuakgoldberg
npm/[email protected] None 0 24.4 kB ai
npm/[email protected] None 0 86.2 kB devongovett
npm/[email protected] environment, filesystem, network, shell, unsafe +14 1.11 GB vercel-release-bot
npm/[email protected] environment, filesystem 0 13.4 kB mafintosh
npm/[email protected] environment, shell Transitive: filesystem, network +55 5.86 MB lukekarrys
npm/[email protected] None 0 97.2 kB ljharb
npm/[email protected] None 0 1.64 MB vitaly
npm/[email protected] filesystem +1 814 kB isaacs
npm/[email protected] None 0 5.21 kB lukekarrys
npm/[email protected] None +2 60 kB achingbrain
npm/[email protected] None 0 33.5 kB google-wombot
npm/[email protected] None +1 415 kB sniphpet
npm/[email protected] None 0 32.2 kB tim-kos
npm/[email protected] Transitive: eval +7 167 kB ljharb
npm/[email protected] Transitive: eval +10 304 kB ljharb
npm/[email protected] None 0 138 kB joshglazebrook
npm/[email protected] network +3 470 kB tootallnate
npm/[email protected] network 0 152 kB joshglazebrook
npm/[email protected] network +1 294 kB joshglazebrook
npm/[email protected] None 0 152 kB area, cgewecke, fvictorio
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +48 34.4 MB area, cgewecke, fvictorio
npm/[email protected] None +1 323 kB npm-cli-ops
npm/[email protected] None 0 4.46 kB mafintosh
npm/[email protected] None +4 127 kB sindresorhus
npm/[email protected] None +1 9.99 kB sindresorhus
npm/[email protected] environment, filesystem +4 272 kB isaacs
npm/[email protected] environment, filesystem, unsafe +3 4.88 MB blakeembrey
npm/[email protected] None 0 73.1 kB ethan_arrowood
npm/[email protected] environment, network, unsafe +1 1.25 MB matteo.collina
npm/[email protected] None +2 17.9 kB lukekarrys
npm/[email protected] None +1 14.5 kB lukekarrys
npm/[email protected] network 0 93.4 MB jmoxey
npm/[email protected] network +1 6.38 MB jmoxey
npm/[email protected] None 0 167 kB gregthegreek, jdevcs, luu-alex, ...1 more
npm/[email protected] None 0 3.73 kB sindresorhus
npm/[email protected] None +6 157 kB sindresorhus

🚮 Removed packages: npm/@babel/[email protected], npm/@lit-labs/[email protected], npm/@motionone/[email protected], npm/@motionone/[email protected], npm/@motionone/[email protected], npm/@motionone/[email protected], npm/@noir-lang/[email protected], npm/@noir-lang/[email protected], npm/@noir-lang/[email protected], npm/@noir-lang/[email protected], npm/@noir-lang/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@scure/[email protected], npm/@typechain/[email protected], npm/@typechain/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented Feb 7, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@signorecello signorecello changed the title Updating to 0.23.0. Documenting new recursion interface DON'T MERGE : Updating to 0.23.0 Feb 8, 2024
critesjosh
critesjosh reviewed Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@critesjosh critesjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recursion README needs to be updated. npx hardhat node doesn't work in the recursion dir.

@signorecello
Copy link
Contributor Author

I'm merging this as 0.23.0 is out @critesjosh. There has a to be a "better" way with wagmi but time is of the essence now because of circuit breaker

@signorecello signorecello merged commit 458d3e7 into master Feb 12, 2024
2 checks passed
@signorecello signorecello deleted the zpedro/recursion_interface branch February 12, 2024 08:57
@signorecello
Copy link
Contributor Author

(I did update the readme though!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@critesjosh critesjosh critesjosh left review comments

@Savio-Sou Savio-Sou Awaiting requested review from Savio-Sou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update noir-examples with the new recursion interface
3 participants
@signorecello @critesjosh @TomAFrench