Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updating examples #11

Closed
wants to merge 3 commits into from
Closed

Conversation

signorecello
Copy link
Contributor

@signorecello signorecello commented Dec 15, 2023

Description

Updates examples to noir version 0.19.4. It also gets rid of ethers on the only example where it was still needed: the recursive example.

Also moved to hardhat ESM.

Problem*

Mitigating potential drift between versions, namely regarding the flattenPublicInputs method.

Copy link
Collaborator

@critesjosh critesjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the recursion and stealthdrop READMEs need to be updated.

@critesjosh
Copy link
Collaborator

critesjosh commented Dec 15, 2023

How long should generating the recursive proof take on the recursion example? It seems to hang and timeout EDIT: it just takes several minutes to generate and several more to verify

image

@signorecello
Copy link
Contributor Author

This is terminally old, closing

@signorecello signorecello deleted the zpedro/update_to_0.19.4 branch February 7, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants