Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding default trait impl #61

Closed
wants to merge 5 commits into from
Closed

feat: adding default trait impl #61

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3edaf34
feat: adding default trait impl
signorecello Nov 29, 2024
c97e883
formatting
signorecello Nov 29, 2024
0302e03
formatting
signorecello Nov 29, 2024
6c26253
Merge branch 'main' into zpedro/default_trait
kashbrti Jan 21, 2025
31a1c57
Merge branch 'main' into zpedro/default_trait
signorecello Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/bignum.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,16 @@ use std::ops::{Add, Div, Mul, Neg, Sub};
pub struct BigNum<let N: u32, let MOD_BITS: u32, Params> {
pub limbs: [Field; N],
}

impl<let N: u32, let MOD_BITS: u32, Params> Default for BigNum<N, MOD_BITS, Params>
where
Params: BigNumParamsGetter<N, MOD_BITS>,
{
fn default() -> Self {
BigNum::new()
}
}

// We aim to avoid needing to add a generic parameter to this trait, for this reason we do not allow
// accessing the limbs of the bignum except through slices.
pub trait BigNumTrait: Neg + Add + Sub + Mul + Div + Eq {
Expand Down