-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adding benchmarking tools for number of brillig opcodes #144
base: main
Are you sure you want to change the base?
Conversation
Looks like you're not making use of |
See https://github.com/noir-lang/noir/blob/master/test_programs/gates_report_brillig.sh for some inspiration (although you can't make use of |
should I do the |
Yeah you need to specify that you want brillig output when you compile. |
@TomAFrench I'm wondering if the format of the outputs generated by the script is compatible with the |
The action expects a JSON object |
Ah, I see you changed to that. Will take a closer look. |
ah then it should be good. The objects in the Json are called |
That's expected. |
with: | ||
report: opcode_report.json | ||
summaryQuantile: 0.9 # only display the 10% most significant circuit size diffs in the summary (defaults to 20%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be marked as a brillig report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Problem*
Resolves
Summary*
Additional Context
PR Checklist*
cargo fmt
on default settings.