websocket: improve frame parsing

[tsctx]

Adjust to avoid creating a temporary buffer

[KhafraDev]

I'd prefer if there was a benchmark to measure the change.

[tsctx]

As an example, the 256Kib receive benchmark is 1.2x faster.

[KhafraDev]

Benchmarking websockets is hard and there is no benchmark to verify.

[tsctx]

Benchmarking websockets is hard and there is no benchmark to verify.

It is a simple benchmark using console.time.
For a correct benchmark, it should be a Parser-only benchmark.

[KhafraDev]

I'd prefer a benchmark that uses WebSocket, not websocket internals. If #3203 could be completed, and then this PR benchmarked against that, I wouldn't have any complaints.

[mcollina]

lgtm

[tsctx]

@KhafraDev Would you be able to revisit this? This is the result of the #3203's of benchmarks.

before / after

> $ node ./benchmarks/websocket-benchmark.mjs
(node:11148) [UNDICI-WSS] Warning: WebSocketStream is experimental! Expect it to change at any time.
(Use `node --trace-warnings ...` to show where the warning was created)
undici [binary]: transferred 95.78MiB Bytes/s
undici [string]: transferred 92.98MiB Bytes/s
undici - stream [binary]: transferred 95.93MiB Bytes/s
undici - stream [string]: transferred 97.00MiB Bytes/s
ws [binary]: transferred 125.82MiB Bytes/s
ws [string]: transferred 117.20MiB Bytes/s
> $ node ./benchmarks/websocket-benchmark.mjs
(node:3924) [UNDICI-WSS] Warning: WebSocketStream is experimental! Expect it to change at any time.
(Use `node --trace-warnings ...` to show where the warning was created)
undici [binary]: transferred 113.48MiB Bytes/s
undici [string]: transferred 112.11MiB Bytes/s
undici - stream [binary]: transferred 106.25MiB Bytes/s
undici - stream [string]: transferred 91.41MiB Bytes/s
ws [binary]: transferred 122.96MiB Bytes/s
ws [string]: transferred 114.50MiB Bytes/s

[mcollina]

@KhafraDev ping

[KhafraDev]

I was hoping to have the websocket benchmarks landed first, but ultimately nothing is stopping this landing.