fixup: rename it to markAsUncloneable

nodejs · Oct 10, 2024 · e6c3af6 · e6c3af6
1 parent ad9f128
commit e6c3af6
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 14 deletions.
diff --git a/lib/web/eventsource/eventsource.js b/lib/web/eventsource/eventsource.js
@@ -109,7 +109,7 @@ class EventSource extends EventTarget {
     // 1. Let ev be a new EventSource object.
     super()
 
-    webidl.util.maybeMarkAsUncloneable(this)
+    webidl.util.markAsUncloneable(this)
 
     const prefix = 'EventSource constructor'
     webidl.argumentLengthCheck(arguments, 1, prefix)

diff --git a/lib/web/fetch/formdata.js b/lib/web/fetch/formdata.js
@@ -14,7 +14,7 @@ class FormData {
   #state = []
 
   constructor (form) {
-    webidl.util.maybeMarkAsUncloneable(this)
+    webidl.util.markAsUncloneable(this)
 
     if (form !== undefined) {
       throw webidl.errors.conversionFailed({

diff --git a/lib/web/fetch/headers.js b/lib/web/fetch/headers.js
@@ -420,7 +420,7 @@ class Headers {
   #headersList
 
   constructor (init = undefined) {
-    webidl.util.maybeMarkAsUncloneable(this)
+    webidl.util.markAsUncloneable(this)
 
     if (init === kConstruct) {
       return

diff --git a/lib/web/fetch/request.js b/lib/web/fetch/request.js
@@ -92,7 +92,7 @@ class Request {
 
   // https://fetch.spec.whatwg.org/#dom-request
   constructor (input, init = undefined) {
-    webidl.util.maybeMarkAsUncloneable(this)
+    webidl.util.markAsUncloneable(this)
 
     if (input === kConstruct) {
       return

diff --git a/lib/web/fetch/response.js b/lib/web/fetch/response.js
@@ -113,7 +113,7 @@ class Response {
 
   // https://fetch.spec.whatwg.org/#dom-response
   constructor (body = null, init = undefined) {
-    webidl.util.maybeMarkAsUncloneable(this)
+    webidl.util.markAsUncloneable(this)
 
     if (body === kConstruct) {
       return

diff --git a/lib/web/fetch/webidl.js b/lib/web/fetch/webidl.js
@@ -120,11 +120,7 @@ webidl.util.TypeValueToString = function (o) {
   }
 }
 
-webidl.util.maybeMarkAsUncloneable = function (target) {
-  if (markAsUncloneable !== undefined) {
-    markAsUncloneable(target)
-  }
-}
+webidl.util.markAsUncloneable = markAsUncloneable || (() => {})
 
 // https://webidl.spec.whatwg.org/#abstract-opdef-converttoint
 webidl.util.ConvertToInt = function (V, bitLength, signedness, opts) {

diff --git a/lib/web/websocket/events.js b/lib/web/websocket/events.js
@@ -14,7 +14,7 @@ class MessageEvent extends Event {
   constructor (type, eventInitDict = {}) {
     if (type === kConstruct) {
       super(arguments[1], arguments[2])
-      webidl.util.maybeMarkAsUncloneable(this)
+      webidl.util.markAsUncloneable(this)
       return
     }
 
@@ -27,7 +27,7 @@ class MessageEvent extends Event {
     super(type, eventInitDict)
 
     this.#eventInit = eventInitDict
-    webidl.util.maybeMarkAsUncloneable(this)
+    webidl.util.markAsUncloneable(this)
   }
 
   get data () {
@@ -114,7 +114,7 @@ class CloseEvent extends Event {
     super(type, eventInitDict)
 
     this.#eventInit = eventInitDict
-    webidl.util.maybeMarkAsUncloneable(this)
+    webidl.util.markAsUncloneable(this)
   }
 
   get wasClean () {

diff --git a/lib/web/websocket/websocket.js b/lib/web/websocket/websocket.js
@@ -100,7 +100,7 @@ class WebSocket extends EventTarget {
   constructor (url, protocols = []) {
     super()
 
-    webidl.util.maybeMarkAsUncloneable(this)
+    webidl.util.markAsUncloneable(this)
 
     const prefix = 'WebSocket constructor'
     webidl.argumentLengthCheck(arguments, 1, prefix)