2.3.4

* make sure to check if initialization was done when ending (Sentry IOBROKER-DISCOVERY-8) * fix megad discovery crash case
nobl · Apr 30, 2020 · baf655a · baf655a
1 parent ec02f7d
commit baf655a
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 22 deletions.
diff --git a/README.md b/README.md
@@ -121,9 +121,13 @@ Just now it can detect via ping, UPnP (serial planned).
 
 ## Changelog
 
+### 2.3.4 (2020-04-30)
+* (Apollon77) make sure to check if initialization was done when ending (Sentry IOBROKER-DISCOVERY-8) 
+* (APollon77) fix megad discovery error
+
 ### 2.3.3 (2020-04-23)
-* correct access to wrong variable (Sentry IOBROKER-DISCOVERY-3)
-* catch http errors better (Sentry IOBROKER-DISCOVERY-2)
+* (Apollon77) correct access to wrong variable (Sentry IOBROKER-DISCOVERY-3)
+* (Apollon77) catch http errors better (Sentry IOBROKER-DISCOVERY-2)
 
 ### 2.3.2 (2020-04-18)
 * (Apollon77) Fix potential crash in knx discovery

diff --git a/lib/adapters/megad.js b/lib/adapters/megad.js
@@ -19,9 +19,9 @@ function addMegaDDevice(ip, device, options, native, callback) {
             }
         };
         options.newInstances.push(instance);
-        callback(null, true, ip);
+        typeof callback === 'function' && callback(null, true, ip);
     } else {
-        callback(null, false, ip);
+        typeof callback === 'function'  && callback(null, false, ip);
     }
 }
 

diff --git a/main.js b/main.js
@@ -468,7 +468,7 @@ let g_browse = null;
 const specialEntryNames = 'name,data,LOCATION'.split(',');
 
 function haltAllMethods() {
-    Object.keys(methods).forEach(method => {
+    methods && Object.keys(methods).forEach(method => {
         // not final
         if (method && method.halt !== undefined) {
             method.halt = true;

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -32,7 +32,7 @@
     "devDependencies": {
         "axios": "^0.19.2",
         "gulp": "^4.0.2",
-        "mocha": "^7.1.1",
+        "mocha": "^7.1.2",
         "chai": "^4.2.0",
         "eslint": "^6.8.0"
     },