Remove endless pagination. Fixes #26

nlhkabu · Jun 13, 2015 · 69d0e56 · 69d0e56 · adrienbrunet · Jun 13, 2015
1 parent e1f8ccf
commit 69d0e56
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 37 deletions.
diff --git a/bdd/features/steps/view_dashboard.py b/bdd/features/steps/view_dashboard.py
@@ -93,16 +93,3 @@ def impl(context):
 def impl(context):
     assert context.browser.is_text_present('Log an abuse report against',
                                            wait_time=DEFAULT_WAIT)
-
-
-# Unique to Scenario: Many users prompt pagination
-@given('there are more than ten users')
-def impl(context):
-    factory.create_batch(UserFactory, 5)
-
-@then('I see that the list of members is paginated')
-def impl(context):
-    assert context.browser.is_element_present_by_css('.pagination')
-
-
-
diff --git a/bdd/features/view_dashboard.feature b/bdd/features/view_dashboard.feature
@@ -52,9 +52,3 @@ Feature: View Dashboard
         When I visit the "dashboard" page
         And I click on "Report Abuse" on another member's card
         Then I am taken to a new page to report that member
-
-    Scenario: Many users prompt pagination
-        Given I am "a logged in user"
-        And there are more than ten users
-        When I visit the "dashboard" page
-        Then I see that the list of members is paginated
diff --git a/connect/discover/templates/discover/list.html b/connect/discover/templates/discover/list.html
@@ -1,5 +1,5 @@
 {% extends "discover/dashboard.html" %}
-{% load endless gravatar i18n staticfiles %}
+{% load gravatar i18n staticfiles %}
 
 {% block page_title %}{% trans "Dashboard" %}{% endblock %}
 
@@ -70,7 +70,6 @@
         </div>
         <div class="twelve columns omega">
             {% if listed_users %}
-                {% paginate listed_users %}
                 {% for user in listed_users %}
                     <!-- start card -->
                     <div class="user-card {% if user != logged_in_user %} not-me{% endif %}">
@@ -159,11 +158,6 @@ <h3><a href="#" class="toggle-user-expand">
                     </div>
                     <!-- end card-->
                 {% endfor %}
-
-                <div class="pagination">
-                    {% show_pages %}
-                </div>
-
             {% else %}
                 <div class="no-results">
                     <h4>{% trans "Sorry!" %}</h4>

diff --git a/connect/settings.py b/connect/settings.py
@@ -35,7 +35,6 @@ def INSTALLED_APPS(self):
             'django.contrib.humanize',
             'django_behave',
             'django_gravatar',
-            'endless_pagination',
             'parsley',
             'connect',
             'connect.config',
@@ -143,16 +142,6 @@ def MIDDLEWARE_CLASSES(self):
 
     # --- BEGIN CONFIGURATIONS FOR THIRD-PARTY APPS --- #
 
-    # ENDLESS PAGINATION
-    from django.conf.global_settings import TEMPLATE_CONTEXT_PROCESSORS
-
-    TEMPLATE_CONTEXT_PROCESSORS += (
-        'django.core.context_processors.request',
-    )
-
-    ENDLESS_PAGINATION_PREVIOUS_LABEL = '<i class="fa fa-chevron-left"></i>'
-    ENDLESS_PAGINATION_NEXT_LABEL = '<i class="fa fa-chevron-right"></i>'
-
     # GRAVATAR
     # See: https://github.com/twaddington/django-gravatar/#configuring
     GRAVATAR_DEFAULT_IMAGE = 'retro'