Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo tests & clippy warnings #375

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

pnmadelaine
Copy link
Contributor

No description provided.

@pnmadelaine pnmadelaine changed the title Fix cargo test Fix cargo tests & clippy warnings Dec 18, 2024
@Ericson2314
Copy link
Collaborator

How does the first commit work? How was skipping a field legal?!

@pnmadelaine
Copy link
Contributor Author

pnmadelaine commented Feb 13, 2025

@Ericson2314 well it's not 😁 the cargo tests were broken, but CI does not run them! (the workfow runs ./run_tests.sh --no-cargo-build which skips them)

@Ericson2314
Copy link
Collaborator

Oh! Lovely....

Well, thank you then!

@Ericson2314 Ericson2314 merged commit be31fea into nix-community:master Feb 13, 2025
2 checks passed
@pnmadelaine pnmadelaine deleted the fix-cargo-test branch February 13, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants