ci: Patch MODULE.bazel in nanobind example #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasjng
force-pushed
the
rework-python-ci
branch
from
b7e93d6 to
1c90d2a
Compare
Done via a small Python script for portability. This ensures that we test the nanobind example build against the latest version in CI.
nicholasjng
force-pushed
the
rework-python-ci
branch
from
1c90d2a to
2611dba
Compare
This was wrong before, but now in Bazel 8 it's a hard error. The problem was that the nanobind_example could not resolve `@platforms` in the select() statement, since it is not a dependency of the example, but needs to be resolved _within_ nanobind-bazel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done via a small Python script for portability. This ensures that we test the nanobind example build against the latest version in CI.