Update nanobind to v2.0.0 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes needed to make the upgrade work: 1) Bump robin-map to v1.3.0. This is due to the added API `erase_fast(iterator pos)` contributed to robin-map that is used in nanobind to avoid expensive lookups in hashmaps. 2) Bump nanobind to v2.0.0. I had to exclude the `nb_combined.cpp` file to fix a compilation error when building libnanobind.
|
cc @hawkinsp. |
Closed
|
My plan is now to issue a new The new BCR release will also probably have to have its |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes needed to make the upgrade work:
erase_fast(iterator pos)contributed to robin-map that is used in nanobind to avoid expensive lookups in hashmaps.
nb_combined.cppfile to fix acompilation error when building libnanobind.
Also includes some core dependency updates in fff5a84.
Addresses #26.
Source thread for the robin-map change is in Tessil/robin-map#76, backstory is contained in wjakob/nanobind#507 and references therein.