Flip minsize option to True by default #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasjng
force-pushed
the
slim-options
branch
from
98286c3 to
76f0f70
Compare
|
what. So I've taken a look at the compile commands on Linux, both look fairly comparable (outside of the PIC stitching in the linker command with Bazel). What is going on here? |
nicholasjng
force-pushed
the
slim-options
branch
2 times, most recently
from
11b172b to
02172e6
Compare
nicholasjng
force-pushed
the
slim-options
branch
from
02172e6 to
30559c4
Compare
|
Searched a bit, found some threads on abi3audit regarding ref-counting symbol false positives. Filed pypa/abi3audit#83 since this result doesn't exactly match the other reports, but I'm strongly assuming this to be a false positive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title.