Skip to content

Commit

Permalink
Try without linking any Windows libs this time
Browse files Browse the repository at this point in the history
  • Loading branch information
nicholasjng committed Mar 22, 2024
1 parent 68dbfd8 commit 1b2e596
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions nanobind.BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,7 @@ package(default_visibility = ["//visibility:public"])
_NB_DEPS = [
"@robin_map",
"@rules_python//python/cc:current_py_cc_headers",
] + select({
# we need to link in the Python libs only on Windows to signal to the linker that it
# needs to go searching for these symbols at runtime.
# TODO: This seems Windows-specific, so change to `@platforms//os:windows`?
"@rules_cc//cc/compiler:msvc-cl": ["@rules_python//python/cc:current_py_cc_libs"],
"//conditions:default": [],
})
]

cc_library(
name = "nanobind",
Expand Down

0 comments on commit 1b2e596

Please sign in to comment.