test: validate go templates with go #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
qvalentin
commented
Jan 14, 2025
•
qvalentin
commented
- Some testnames are still ugly
- corpus_test.go:29: template: template:2: missing value for block clause -> it is working, I found a bug ;)
- ci
qvalentin
changed the title
qvalentin
force-pushed
the
test/validate-go-templates-with-go
branch
2 times, most recently
from
39e190b to
e54ee93
Compare
guilhas07
reviewed
Jan 15, 2025
qvalentin
force-pushed
the
test/validate-go-templates-with-go
branch
from
0c14f5f to
9ec3efb
Compare
guilhas07
approved these changes
Jan 17, 2025
this ensures all testcases obey the gotemplate grammar and we are compatible with the official implementation
qvalentin
force-pushed
the
test/validate-go-templates-with-go
branch
from
9ec3efb to
eb02adf
Compare
Co-authored-by: Guilherme Soares <[email protected]>
|
Good job with the review @guilhas07 😄 |
Thanks! It was actually my first one 😅. Happy to help anytime! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.