Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link to image in README.md #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

belonesox
Copy link

No description provided.

@blizzz
Copy link
Member

blizzz commented Nov 22, 2023

Indeed your fix would fix the path.

Actually it is a wrong screenshot thought, and refers only to that one already shown on top of the read me. Once upon a time, this screenshot was being used there: https://github.com/nextcloud/workflow_script/blob/ee8753ffa59ff0bd5842692160267d5be094f660/screenshots/example_rule.png

@belonesox do you fancy to take a new, up to date one and place it there?

@belonesox
Copy link
Author

belonesox commented Nov 22, 2023

Hmm... I can, but screenshot for my example workflow (I spent several hours, debugging generation of PDF from xournal, what placeholders substitutes is not obvious), and I cannot reproduce the example workflow with «style and students». Actually, placeholder for root data (like /var/data/xournalpp) directory looks missing, and I have to hardcore it.

Should I describe the whole my case (and how to debug problems?)

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz
Copy link
Member

blizzz commented Jan 15, 2024

@belonesox Sorry, this went under 😞

It is not necessary to replicate the example with style, any other does as well.

Actually, placeholder for root data (like /var/data/xournalpp) directory looks missing, and I have to hardcore it.

If a place holder for the data dir is necessary, such can be added. Should not be a big issue I think, can be taken straight from the config. That would go into a separate PR though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants