Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: IdP Post #861

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: IdP Post #861

wants to merge 1 commit into from

Conversation

hweihwang
Copy link

No description provided.

@hweihwang hweihwang requested a review from blizzz July 1, 2024 09:31
blizzz
blizzz reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not tested yet, looks good on first sight, just two small nitpicks (and knowing about the open questions).

lib/Controller/SAMLController.php Outdated Show resolved Hide resolved
templates/login_post.php Outdated Show resolved Hide resolved
@hweihwang hweihwang force-pushed the feat/post-login branch 2 times, most recently from 7551b07 to e8c669b Compare July 4, 2024 09:16
@hweihwang hweihwang requested a review from blizzz July 5, 2024 05:10
blizzz
blizzz requested changes Jul 5, 2024
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the post if-branch in login().

When modifying this locally and testing with keycloak I receive "We are sorry... Invalid Request". But it could be my Keycloak config needs adjustment, if it supports that.

templates/login_post.php Show resolved Hide resolved
lib/Controller/SAMLController.php Outdated Show resolved Hide resolved
blizzz
blizzz reviewed Jul 9, 2024
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works 👍

Any luck with shibboleth integration tests yet?

@hweihwang hweihwang requested a review from blizzz July 12, 2024 10:58
@hweihwang
feat: Post login Idp
93b9a22 
Signed-off-by: Hoang Pham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hweihwang @blizzz