fix(recursiveDelete): Handle symlinked folders correctly #554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#184 added some handling for symlinks in
recurseDelete()
but only for files, not directories.We don't use
recursiveDelete()
is many places where this is likely to happen currently, but sinceisDir()
resolves/matches on symbolic links it's possible we wouldrmdir()
(and so against thegetRealPath()
) rather thanunlink()
it. This would result in trying to:rmdir()
against a symlinkrmdir()
against the same target more than onceWe use
recusriveDelete()
to: