[stable29] fix(files_sharing): Respect permissions passed when creating link shares #50272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given: User creates a link or email share with permissions=4 (create only = file drop). Problem: Currently the permissions are automatically extended to permissions = 5 (READ + CREATE). Work around was to create the share and directly update it. Solution: Respect what the user is requesting, create a file drop share. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
changed the title
4 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Shares always require read permissions | ||
| $permissions |= Constants::PERMISSION_READ; | ||
| if ($shareType === IShare::TYPE_LINK || $shareType === IShare::TYPE_EMAIL) { | ||
| $permissions = $this->getLinkSharePermissions($permissions, $publicUpload); |
Check notice
Code scanning / Psalm
PossiblyNullArgument Note
| } else { | ||
| // Use default permissions only for non-link shares to keep legacy behavior | ||
| if ($permissions === null) { | ||
| $permissions = (int)$this->config->getAppValue('core', 'shareapi_default_permissions', (string)Constants::PERMISSION_ALL); |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #50270