🚀 3단계 - 리팩터링(매장 식사 주문)

src/main/java/kitchenpos/menus/application/MenuProductMapper.java

@@ -0,0 +1,62 @@
+package kitchenpos.menus.application;
+
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.UUID;
+import kitchenpos.menus.application.dto.MenuProductCreateRequest;
+import kitchenpos.menus.application.dto.MenuProductsCreateRequest;
+import kitchenpos.menus.domain.tobe.MenuProduct;
+import kitchenpos.menus.domain.tobe.MenuProductsValidator;
+import kitchenpos.menus.domain.tobe.MenuProducts;
+import kitchenpos.menus.domain.tobe.ProductQuantity;
+import kitchenpos.products.domain.ProductRepository;
+import kitchenpos.products.domain.tobe.Product;
+import org.springframework.stereotype.Component;
+
+@Component
+public class MenuProductMapper {
+
+    private final ProductRepository productRepository;
+    private final MenuProductsValidator menuProductsValidator;
+
+    public MenuProductMapper(ProductRepository productRepository,
+        MenuProductsValidator menuProductValidator) {
+        this.productRepository = productRepository;
+        this.menuProductsValidator = menuProductValidator;
+    }
+
+    public MenuProducts map(MenuProductsCreateRequest request) {
+        List<UUID> productIds = request.menuProducts()
+            .stream().map(MenuProductCreateRequest::productId)
+            .toList();
+
+        List<Product> products = productRepository.findAllByIdIn(productIds);
+        List<MenuProduct> menuProducts = createMenuProducts(request, products);
+        menuProductsValidator.validate(menuProducts, products);
+        return new MenuProducts(menuProducts);
+    }
+
+    private List<MenuProduct> createMenuProducts(MenuProductsCreateRequest menuProducts,
+        List<Product> products) {
+        return menuProducts.menuProducts()
+            .stream()
+            .map(menuProduct -> createMenuProduct(products,
+                menuProduct.productId(),
+                menuProduct.quantity())
+            )
+            .toList();
+    }
+
+    private MenuProduct createMenuProduct(List<Product> products,
+        UUID productId,
+        ProductQuantity quantity) {
+        Product product = findProduct(products, productId);
+        return new MenuProduct(product, quantity);
+    }
+
+    private Product findProduct(List<Product> products, UUID productId) {
+        return products.stream()
+            .filter(product -> product.getId().equals(productId))
+            .findFirst().orElseThrow((NoSuchElementException::new));
+    }
+}

src/main/java/kitchenpos/menus/application/MenuService.java

@@ -4,12 +4,12 @@
 import java.util.NoSuchElementException;
 import java.util.UUID;
 import kitchenpos.menugroups.domain.MenuGroupRepository;
+import kitchenpos.menugroups.domain.tobe.MenuGroup;
+import kitchenpos.menus.application.dto.MenuCreateRequest;
 import kitchenpos.menus.domain.MenuRepository;
 import kitchenpos.menus.domain.tobe.Menu;
 import kitchenpos.menus.domain.tobe.MenuPrice;
 import kitchenpos.menus.domain.tobe.MenuProducts;
-import kitchenpos.menugroups.domain.tobe.MenuGroup;
-import kitchenpos.menus.ui.dto.MenuCreateRequest;
 import kitchenpos.products.domain.ProfanityValidator;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
@@ -20,41 +20,43 @@ public class MenuService {
     private final MenuRepository menuRepository;
     private final MenuGroupRepository menuGroupRepository;
     private final ProfanityValidator profanityValidator;
-    private final MenuProductsService menuProductsService;
+    private final MenuProductMapper menuProductMapper;
 
-    public MenuService(
-            final MenuRepository menuRepository,
-            final MenuGroupRepository menuGroupRepository,
-            final ProfanityValidator profanityValidator,
-            final MenuProductsService menuProductsService
-    ) {
+    public MenuService(MenuRepository menuRepository, MenuGroupRepository menuGroupRepository,
+        ProfanityValidator profanityValidator, MenuProductMapper menuProductMapper) {
         this.menuRepository = menuRepository;
         this.menuGroupRepository = menuGroupRepository;
         this.profanityValidator = profanityValidator;
-        this.menuProductsService = menuProductsService;
+        this.menuProductMapper = menuProductMapper;
     }
 
     @Transactional
     public Menu create(final MenuCreateRequest request) {
-        request.validateName(profanityValidator);
-        final MenuGroup menuGroup = findMenuGroup(request.getMenuGroupId());
-        final MenuProducts menuProducts = menuProductsService.create(request.getMenuProducts(),
-                request.getPrice());
-        return menuRepository.save(request.to(menuGroup, menuProducts));
+        profanityValidator.validate(request.name().getName());
+        final MenuGroup menuGroup = findMenuGroup(request.menuGroupId());
+        final MenuProducts menuProducts = menuProductMapper.map(
+            request.menuProductsCreateRequest());
+
+        final Menu menu = new Menu(
+            request.name(),
+            request.price(),
+            menuGroup,
+            request.displayed(),
+            menuProducts);
+        return menuRepository.save(menu);
     }
 
+
     @Transactional
     public Menu changePrice(final UUID menuId, final MenuPrice request) {
         final Menu menu = findMenu(menuId);
-        menuProductsService.validateMenuPrice(menu.getMenuProducts(), request);
         menu.changePrice(request);
         return menu;
     }
 
     @Transactional
     public Menu display(final UUID menuId) {
         final Menu menu = findMenu(menuId);
-        menuProductsService.validateMenuPrice(menu.getMenuProducts(), menu.getMenuPrice());
         menu.display();
         return menu;
     }
@@ -73,11 +75,11 @@ public List<Menu> findAll() {
 
     private MenuGroup findMenuGroup(UUID menuGroupId) {
         return menuGroupRepository.findById(menuGroupId)
-                .orElseThrow(NoSuchElementException::new);
+            .orElseThrow(NoSuchElementException::new);
     }
 
     private Menu findMenu(UUID menuId) {
         return menuRepository.findById(menuId)
-                .orElseThrow(NoSuchElementException::new);
+            .orElseThrow(NoSuchElementException::new);
     }
 }

src/main/java/kitchenpos/menus/application/dto/MenuCreateRequest.java

@@ -0,0 +1,15 @@
+package kitchenpos.menus.application.dto;
+
+import jakarta.validation.constraints.NotNull;
+import java.util.UUID;
+import kitchenpos.menus.domain.tobe.DisplayedMenu;
+import kitchenpos.menus.domain.tobe.MenuName;
+import kitchenpos.menus.domain.tobe.MenuPrice;
+
+public record MenuCreateRequest(@NotNull MenuName name,
+                                @NotNull MenuPrice price,
+                                @NotNull UUID menuGroupId,
+                                @NotNull DisplayedMenu displayed,
+                                @NotNull MenuProductsCreateRequest menuProductsCreateRequest) {
+
+}

src/main/java/kitchenpos/menus/application/dto/MenuProductCreateRequest.java

@@ -0,0 +1,10 @@
+package kitchenpos.menus.application.dto;
+
+import jakarta.validation.constraints.NotNull;
+import java.util.UUID;
+import kitchenpos.menus.domain.tobe.ProductQuantity;
+
+public record MenuProductCreateRequest(@NotNull UUID productId,
+                                       @NotNull ProductQuantity quantity) {
+
+}

src/main/java/kitchenpos/menus/application/dto/MenuProductsCreateRequest.java

@@ -0,0 +1,8 @@
+package kitchenpos.menus.application.dto;
+
+import jakarta.validation.constraints.NotEmpty;
+import java.util.List;
+
+public record MenuProductsCreateRequest(@NotEmpty List<MenuProductCreateRequest> menuProducts) {
+
+}

src/main/java/kitchenpos/menus/domain/tobe/Menu.java

@@ -3,16 +3,12 @@
 import jakarta.persistence.Column;
 import jakarta.persistence.Embedded;
 import jakarta.persistence.Entity;
-import jakarta.persistence.ForeignKey;
 import jakarta.persistence.Id;
-import jakarta.persistence.JoinColumn;
-import jakarta.persistence.ManyToOne;
 import jakarta.persistence.Table;
-import jakarta.persistence.Transient;
 import java.math.BigDecimal;
-import java.util.List;
 import java.util.UUID;
 import kitchenpos.menugroups.domain.tobe.MenuGroup;
+import kitchenpos.products.domain.tobe.ProductPrice;
 
 @Table(name = "menu")
 @Entity
@@ -40,32 +36,56 @@ protected Menu() {
     }
 
     public Menu(MenuName name, MenuPrice price, MenuGroup menuGroup, DisplayedMenu displayed,
-            MenuProducts menuProducts) {
-        this(UUID.randomUUID(), name, price, menuGroup.getId(), displayed, menuProducts);
-    }
-
-    public Menu(UUID id, MenuName name, MenuPrice price, UUID menuGroupId,
-            DisplayedMenu displayed, MenuProducts menuProducts) {
-        this.id = id;
+        MenuProducts menuProducts) {
+        validateMenuPrice(price, menuProducts);
+        this.id = UUID.randomUUID();
         this.name = name;
         this.price = price;
-        this.menuGroupId = menuGroupId;
+        this.menuGroupId = menuGroup.getId();
         this.displayed = displayed;
         this.menuProducts = menuProducts;
     }
 
+    private static void validateMenuPrice(MenuPrice price, MenuProducts menuProducts) {
+        if (price.isOver(menuProducts.calculateSumPrice())) {
+            throw new IllegalArgumentException();
+        }
+    }
+
     public void changePrice(MenuPrice price) {
+        if (price.isOver(menuProducts.calculateSumPrice())) {
+            throw new IllegalArgumentException();
+        }
         this.price = price;
     }
 
     public void display() {
+        if (isOverThanProductSumPrice()) {
+            throw new IllegalArgumentException();
+        }
         this.displayed = new DisplayedMenu(true);
     }
 
+    public boolean isOverThanProductSumPrice() {
+        return price.isOver(menuProducts.calculateSumPrice());
+    }
+
     public void hide() {
         this.displayed = new DisplayedMenu(false);
     }
 
+    public void changeMenuProductPrice(UUID productId, ProductPrice price) {
+        for (MenuProduct menuProduct : menuProducts) {
+            if (menuProduct.getProductId().equals(productId)) {
+                menuProduct.changePrice(price);
+            }
+        }
+
+        if (isOverThanProductSumPrice()) {
+            hide();
+        }
+    }
+
     public boolean isDisplayed() {
         return this.displayed.isDisplayed();
     }
@@ -74,15 +94,11 @@ public UUID getId() {
         return id;
     }
 
-    public MenuPrice getMenuPrice() {
-        return price;
-    }
-
     public BigDecimal getPrice() {
         return price.getPrice();
     }
 
-    public List<MenuProduct> getMenuProducts() {
-        return menuProducts.getMenuProducts();
+    public MenuProducts getMenuProducts() {
+        return menuProducts;
     }
 }