2단계 - 리팩터링(메뉴)

src/main/java/kitchenpos/menu/api/MenuGroupRestController.java

@@ -3,6 +3,7 @@
 import java.net.URI;
 import java.util.List;
 import kitchenpos.menu.application.MenuGroupService;
+import kitchenpos.menu.tobe.application.dto.CreateMenuGroupCommand;
 import kitchenpos.menu.tobe.domain.entity.MenuGroup;
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.GetMapping;
@@ -21,7 +22,7 @@ public MenuGroupRestController(final MenuGroupService menuGroupService) {
     }
 
     @PostMapping
-    public ResponseEntity<MenuGroup> create(@RequestBody final MenuGroup request) {
+    public ResponseEntity<MenuGroup> create(@RequestBody final CreateMenuGroupCommand request) {
         final MenuGroup response = menuGroupService.create(request);
         return ResponseEntity.created(URI.create("/api/menu-groups/" + response.id))
             .body(response);

src/main/java/kitchenpos/menu/application/MenuGroupService.java

@@ -1,28 +1,32 @@
 package kitchenpos.menu.application;
 
 import java.util.List;
-import java.util.Objects;
 import java.util.UUID;
 import kitchenpos.common.name.Name;
+import kitchenpos.common.name.NameFactory;
+import kitchenpos.menu.tobe.application.dto.CreateMenuGroupCommand;
 import kitchenpos.menu.tobe.domain.entity.MenuGroup;
 import kitchenpos.menu.tobe.domain.repository.MenuGroupRepository;
+import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
 @Service
 public class MenuGroupService {
+
     private final MenuGroupRepository menuGroupRepository;
 
-    public MenuGroupService(final MenuGroupRepository menuGroupRepository) {
+    private final NameFactory nameFactory;
+
+    @Autowired
+    public MenuGroupService(MenuGroupRepository menuGroupRepository, NameFactory nameFactory) {
         this.menuGroupRepository = menuGroupRepository;
+        this.nameFactory = nameFactory;
     }
 
     @Transactional
-    public MenuGroup create(final MenuGroup request) {
-        final Name name = request.name;
-        if (Objects.isNull(name)) {
-            throw new IllegalArgumentException();
-        }
+    public MenuGroup create(final CreateMenuGroupCommand request) {
+        final Name name = this.nameFactory.create(request.name);
         final MenuGroup menuGroup = new MenuGroup(UUID.randomUUID(), name);
         return menuGroupRepository.save(menuGroup);
     }

src/main/java/kitchenpos/menu/tobe/application/dto/CreateMenuGroupCommand.java

@@ -0,0 +1,10 @@
+package kitchenpos.menu.tobe.application.dto;
+
+public class CreateMenuGroupCommand {
+
+    public final String name;
+
+    public CreateMenuGroupCommand(String name) {
+        this.name = name;
+    }
+}

src/test/java/kitchenpos/menu/application/MenuGroupServiceTest.java

@@ -9,6 +9,7 @@
 import kitchenpos.common.profanity.FakeProfanityDetectService;
 import kitchenpos.common.profanity.domain.ProfanityDetectService;
 import kitchenpos.menu.InMemoryMenuGroupRepository;
+import kitchenpos.menu.tobe.application.dto.CreateMenuGroupCommand;
 import kitchenpos.menu.tobe.domain.entity.MenuGroup;
 import kitchenpos.menu.tobe.domain.repository.MenuGroupRepository;
 import org.junit.jupiter.api.BeforeEach;
@@ -21,25 +22,23 @@ class MenuGroupServiceTest {
 
     private MenuGroupService menuGroupService;
 
-    private NameFactory nameFactory;
-
     @BeforeEach
     void setUp() {
         menuGroupRepository = new InMemoryMenuGroupRepository();
-        menuGroupService = new MenuGroupService(menuGroupRepository);
         final ProfanityDetectService profanityDetectService = new FakeProfanityDetectService();
-        nameFactory = new NameFactory(profanityDetectService);
+        final NameFactory nameFactory = new NameFactory(profanityDetectService);
+        menuGroupService = new MenuGroupService(menuGroupRepository, nameFactory);
     }
 
     @DisplayName("메뉴 그룹을 등록할 수 있다.")
     @Test
     void create() {
-        final MenuGroup expected = createMenuGroupRequest("두마리메뉴");
-        final MenuGroup actual = menuGroupService.create(expected);
+        final CreateMenuGroupCommand command = createMenuGroupCommand("두마리메뉴");
+        final MenuGroup actual = menuGroupService.create(command);
         assertThat(actual).isNotNull();
         assertAll(
             () -> assertThat(actual.id).isNotNull(),
-            () -> assertThat(actual.name).isEqualTo(expected.name)
+            () -> assertThat(actual.name.value).isEqualTo(command.name)
         );
     }
 
@@ -51,7 +50,7 @@ void findAll() {
         assertThat(actual).hasSize(1);
     }
 
-    private MenuGroup createMenuGroupRequest(final String name) {
-        return new MenuGroup(null, this.nameFactory.create(name));
+    private CreateMenuGroupCommand createMenuGroupCommand(final String name) {
+        return new CreateMenuGroupCommand(name);
     }
 }