[Step1] 리팩터링(상품) #115
Open
[Step1] 리팩터링(상품) #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
kitchenpos product bounded context의 리펙터링입니다
설명
product 도메인의 필드를 value object로 변경하고 service layer를 얇게 변경하였습니다. 그리고 통신을 위해서 dto(request, response) 를 추가하였습니다.
기존 service layer에 다른 bounded context인 menu 도메인의 hide / display 하는 부분은 제거하였습니다. 해당 부분은 후에 batch 혹은 메시지 처리 등을 이용하여 finally consistency를 유지하는 것으로 충분하다고 생각했습니다.
내용 확인 부탁드립니다. 감사합니다 : )