-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
๐ 3๋จ๊ณ - ๊ธฐ๋ฅ ์ฐ์ ํจํค์ง ๊ตฌ์ฑํ๊ธฐ #433
base: deepredk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์๋
ํ์ธ์ ์ค์ฑ๋! ํจํค์ง ์ ๋ฆฌ ์ ์งํํด์ฃผ์
จ์ต๋๋ค.
์ฃผ๋ฌธ๊ฐ์ ์๋ก ๋ค์์ธ ๋ถ๋ถ๋ค์ด ์กฐ๊ธ ์๋ ๊ฒ ๊ฐ์์!
๊ด๋ จํ์ฌ ์ฝ๋ฉํธ ๋จ๊ฒผ์ผ๋ ํ์ธํด์ฃผ์ธ์!
package kitchenpos.product.application; | ||
|
||
import kitchenpos.domain.Menu; | ||
import kitchenpos.domain.MenuProduct; | ||
import kitchenpos.domain.MenuRepository; | ||
import kitchenpos.domain.Product; | ||
import kitchenpos.domain.ProductRepository; | ||
import kitchenpos.infra.PurgomalumClient; | ||
import kitchenpos.menu.domain.Menu; | ||
import kitchenpos.menu.domain.MenuProduct; | ||
import kitchenpos.menu.domain.MenuRepository; | ||
import kitchenpos.product.domain.Product; | ||
import kitchenpos.product.domain.ProductRepository; | ||
import kitchenpos.common.infra.PurgomalumClient; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ํ์ฌ product ํจํค์ง์์ menu ํจํค์ง์ ๋ํ ์์กด์ด ์งํ๋๊ณ ์๋๋ฐ์, ์ด๋ฅผ ์์จ๋งํ ๋ฐฉ๋ฒ์ ๋ฌด์์ด ์์๊น์?
๊ธฐ์ ์ ์ธ ํด๊ฒฐ๋ฐฉ๋ฒ ๋ฟ๋ง ์๋๋ผ, ์ค๊ณ์ ์ธ ์ธก๋ฉด์์ "๊ผญ product ๊ฐ menu ๋ฅผ ์์์ผํ ๊น?" ๊ณ ๋ฏผํด๋ณด๋ฉด ๋์ฑ ์ข๊ฒ ๋ค์!
import kitchenpos.menu.domain.Menu; | ||
import kitchenpos.menu.domain.MenuGroup; | ||
import kitchenpos.menu.domain.MenuGroupRepository; | ||
import kitchenpos.menu.domain.MenuProduct; | ||
import kitchenpos.menu.domain.MenuRepository; | ||
import kitchenpos.product.domain.Product; | ||
import kitchenpos.product.domain.ProductRepository; | ||
import kitchenpos.common.infra.PurgomalumClient; | ||
import org.springframework.stereotype.Service; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
menu ๋ product ์ ๋ํ ์์กด์ ์ด๋์ ๋ ๊ฐ์ง ์ ์๋ค๊ณ ์๊ฐํด์!
๋ค๋ง ํ์ต์ ์ํด์ ๋ถ๋ฆฌ๋ฅผ ์๋ํด๋ณด๋ ๊ฒ๋ ์ข์ ๊ฒ ๊ฐ์๋ฐ... ์ด๋ค ๋ฐฉ๋ฒ์ด ์์๊น์? ๐
package kitchenpos.order.delivery_order.domain; | ||
|
||
import kitchenpos.order.common.domain.Order; | ||
|
||
public class DeliveryOrder extends Order { | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์์์ ์ด์ฉํด์ฃผ์ จ๊ตฐ์!
package kitchenpos.order.delivery_order.domain; | ||
|
||
import java.util.List; | ||
import java.util.Optional; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ฃผ๋ฌธ ํ ์ด๋ธ์ด ๋ฐฐ๋ฌ์ฃผ๋ฌธ์ ํฌํจ?! ๐ฑ
package kitchenpos.order.delivery_order.infra; | ||
|
||
import org.springframework.stereotype.Component; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋ฐฐ๋ฌ ๊ตฌํ์ฒด๊ฐ ์ธ๋ถ ํ๋ก๊ทธ๋จ(ํด๋ผ์ด์ธํธ)์์ ์ฐ๋ฆฌ ๋น์ฆ๋์ค์์ ๊ผญ ์์์ผํ ๊น์? ๐ค
package kitchenpos.order.eat_in_order.application; | ||
|
||
import kitchenpos.domain.OrderRepository; | ||
import kitchenpos.domain.OrderStatus; | ||
import kitchenpos.domain.OrderTable; | ||
import kitchenpos.domain.OrderTableRepository; | ||
import kitchenpos.legacy.domain.OrderRepository; | ||
import kitchenpos.legacy.domain.OrderStatus; | ||
import kitchenpos.order.delivery_order.domain.OrderTable; | ||
import kitchenpos.order.delivery_order.domain.OrderTableRepository; | ||
import org.springframework.stereotype.Service; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋งค์ฅ์ฃผ๋ฌธ์ ๋ ๊ฑฐ์์ ๋ฐฐ๋ฌ์ฃผ๋ฌธ์ด ๋ค์์ฌ ์๋ ๊ฒ ๊ฐ์์ ๐ฑ
์๋ ํ์ธ์ ๋ฆฌ๋ทฐ์ด๋! 3๋จ๊ณ๋ ์ ๋ถํ๋๋ฆฝ๋๋ค
์ฝ๋๋ ์ ๊ฒฝ์ฐ์ง ์๊ณ ์ค์ง ํจํค์ง ๊ตฌ์กฐ๋ง ์ ๊ฒฝ์จ์ ๋๋ ๋ดค์ต๋๋ค