Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿš€ 3๋‹จ๊ณ„ - ๊ธฐ๋Šฅ ์šฐ์„  ํŒจํ‚ค์ง€ ๊ตฌ์„ฑํ•˜๊ธฐ #433

Open
wants to merge 1 commit into
base: deepredk
Choose a base branch
from

Conversation

deepredk
Copy link

@deepredk deepredk commented Jun 3, 2024

์•ˆ๋…•ํ•˜์„ธ์š” ๋ฆฌ๋ทฐ์–ด๋‹˜! 3๋‹จ๊ณ„๋„ ์ž˜ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค
์ฝ”๋“œ๋Š” ์‹ ๊ฒฝ์“ฐ์ง€ ์•Š๊ณ  ์˜ค์ง ํŒจํ‚ค์ง€ ๊ตฌ์กฐ๋งŒ ์‹ ๊ฒฝ์จ์„œ ๋‚˜๋ˆ ๋ดค์Šต๋‹ˆ๋‹ค

Copy link
Member

@Hyeon9mak Hyeon9mak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•ˆ๋…•ํ•˜์„ธ์š” ์ค€์„ฑ๋‹˜! ํŒจํ‚ค์ง€ ์ •๋ฆฌ ์ž˜ ์ง„ํ–‰ํ•ด์ฃผ์…จ์Šต๋‹ˆ๋‹ค.
์ฃผ๋ฌธ๊ฐ„์— ์„œ๋กœ ๋’ค์„ž์ธ ๋ถ€๋ถ„๋“ค์ด ์กฐ๊ธˆ ์žˆ๋Š” ๊ฒƒ ๊ฐ™์•„์š”!
๊ด€๋ จํ•˜์—ฌ ์ฝ”๋ฉ˜ํŠธ ๋‚จ๊ฒผ์œผ๋‹ˆ ํ™•์ธํ•ด์ฃผ์„ธ์š”!

Comment on lines +1 to +8
package kitchenpos.product.application;

import kitchenpos.domain.Menu;
import kitchenpos.domain.MenuProduct;
import kitchenpos.domain.MenuRepository;
import kitchenpos.domain.Product;
import kitchenpos.domain.ProductRepository;
import kitchenpos.infra.PurgomalumClient;
import kitchenpos.menu.domain.Menu;
import kitchenpos.menu.domain.MenuProduct;
import kitchenpos.menu.domain.MenuRepository;
import kitchenpos.product.domain.Product;
import kitchenpos.product.domain.ProductRepository;
import kitchenpos.common.infra.PurgomalumClient;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ˜„์žฌ product ํŒจํ‚ค์ง€์—์„œ menu ํŒจํ‚ค์ง€์— ๋Œ€ํ•œ ์˜์กด์ด ์ง„ํ–‰๋˜๊ณ  ์žˆ๋Š”๋ฐ์š”, ์ด๋ฅผ ์—†์•จ๋งŒํ•œ ๋ฐฉ๋ฒ•์€ ๋ฌด์—‡์ด ์žˆ์„๊นŒ์š”?
๊ธฐ์ˆ ์ ์ธ ํ•ด๊ฒฐ๋ฐฉ๋ฒ• ๋ฟ๋งŒ ์•„๋‹ˆ๋ผ, ์„ค๊ณ„์ ์ธ ์ธก๋ฉด์—์„œ "๊ผญ product ๊ฐ€ menu ๋ฅผ ์•Œ์•„์•ผํ• ๊นŒ?" ๊ณ ๋ฏผํ•ด๋ณด๋ฉด ๋”์šฑ ์ข‹๊ฒ ๋„ค์š”!

Comment on lines +3 to 11
import kitchenpos.menu.domain.Menu;
import kitchenpos.menu.domain.MenuGroup;
import kitchenpos.menu.domain.MenuGroupRepository;
import kitchenpos.menu.domain.MenuProduct;
import kitchenpos.menu.domain.MenuRepository;
import kitchenpos.product.domain.Product;
import kitchenpos.product.domain.ProductRepository;
import kitchenpos.common.infra.PurgomalumClient;
import org.springframework.stereotype.Service;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

menu ๋Š” product ์— ๋Œ€ํ•œ ์˜์กด์„ ์–ด๋Š์ •๋„ ๊ฐ€์งˆ ์ˆ˜ ์žˆ๋‹ค๊ณ  ์ƒ๊ฐํ•ด์š”!
๋‹ค๋งŒ ํ•™์Šต์„ ์œ„ํ•ด์„œ ๋ถ„๋ฆฌ๋ฅผ ์‹œ๋„ํ•ด๋ณด๋Š” ๊ฒƒ๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์€๋ฐ... ์–ด๋–ค ๋ฐฉ๋ฒ•์ด ์žˆ์„๊นŒ์š”? ๐Ÿ˜‰

Comment on lines +1 to +6
package kitchenpos.order.delivery_order.domain;

import kitchenpos.order.common.domain.Order;

public class DeliveryOrder extends Order {
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ƒ์†์„ ์ด์šฉํ•ด์ฃผ์…จ๊ตฐ์š”!

Comment on lines +1 to 4
package kitchenpos.order.delivery_order.domain;

import java.util.List;
import java.util.Optional;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ฃผ๋ฌธ ํ…Œ์ด๋ธ”์ด ๋ฐฐ๋‹ฌ์ฃผ๋ฌธ์— ํฌํ•จ?! ๐Ÿ˜ฑ

Comment on lines +1 to 4
package kitchenpos.order.delivery_order.infra;

import org.springframework.stereotype.Component;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฐฐ๋‹ฌ ๊ตฌํ˜„์ฒด๊ฐ€ ์™ธ๋ถ€ ํ”„๋กœ๊ทธ๋žจ(ํด๋ผ์ด์–ธํŠธ)์ž„์„ ์šฐ๋ฆฌ ๋น„์ฆˆ๋‹ˆ์Šค์—์„œ ๊ผญ ์•Œ์•„์•ผํ• ๊นŒ์š”? ๐Ÿค”

Comment on lines +1 to 7
package kitchenpos.order.eat_in_order.application;

import kitchenpos.domain.OrderRepository;
import kitchenpos.domain.OrderStatus;
import kitchenpos.domain.OrderTable;
import kitchenpos.domain.OrderTableRepository;
import kitchenpos.legacy.domain.OrderRepository;
import kitchenpos.legacy.domain.OrderStatus;
import kitchenpos.order.delivery_order.domain.OrderTable;
import kitchenpos.order.delivery_order.domain.OrderTableRepository;
import org.springframework.stereotype.Service;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋งค์žฅ์ฃผ๋ฌธ์— ๋ ˆ๊ฑฐ์‹œ์™€ ๋ฐฐ๋‹ฌ์ฃผ๋ฌธ์ด ๋’ค์„ž์—ฌ ์žˆ๋Š” ๊ฒƒ ๊ฐ™์•„์š” ๐Ÿ˜ฑ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants