3단계 - 기능 우선 패키지 #411
Open
3단계 - 기능 우선 패키지 #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liquidjoo
requested changes
May 26, 2024
Comment on lines
+8
to
+9
| import kitchenpos.domain.product.Product; | ||
| import kitchenpos.domain.product.ProductRepository; |
There was a problem hiding this comment.
menu service 영역에 product 패키지가 의존되는 것 같은데요
이런 부분도 한번 의존성을 제거해보면 어떨까요?
Comment on lines
+3
to
+4
| import kitchenpos.domain.menu.Menu; | ||
| import kitchenpos.domain.menu.MenuRepository; |
There was a problem hiding this comment.
주문서 서비스에 menu 패키지가 의존되는 것을 어떻게 막아볼 수 있을까요?
Comment on lines
+3
to
+5
| import kitchenpos.domain.menu.Menu; | ||
| import kitchenpos.domain.menu.MenuProduct; | ||
| import kitchenpos.domain.menu.MenuRepository; |
| @@ -10,6 +10,7 @@ | |||
| import jakarta.persistence.ManyToOne; | |||
| import jakarta.persistence.Table; | |||
| import jakarta.persistence.Transient; | |||
| import kitchenpos.domain.product.Product; | |||
There was a problem hiding this comment.
MenuProduct 와 Product 는 같은 영역의 컨텍스트일까요?
| import jakarta.persistence.ManyToOne; | ||
| import jakarta.persistence.Table; | ||
| import jakarta.persistence.Transient; | ||
| import kitchenpos.domain.menu.Menu; |
There was a problem hiding this comment.
다음 미션인 리팩터링의 영역을 조금 침범할 수 도 있지만 고려해보면 좋을 것 같아요 :)
|
|
||
| @Table(name = "order_line_item") | ||
| @Entity | ||
| public class DeliveryOrderLineItem { |
There was a problem hiding this comment.
새롭게 만들어진 영역의 컨텍스트가 있으면 테스트 코드 또한 작성해봐야 좋을 것 같습니다
테스트 코드가 리팩터링 후에도 유효해야하기 때문에 작성하는 것을 추천합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내역
궁금한 점