AWS Kinesis Delivery Streams (Firehose) Entity Mapping

[TimPansino]

Overview

• Add instrumentation and tests for AWS Firehose.
• Correct AWS Kinesis Instrumentation naming when no stream target is present.
• Tweak boto3/botocore in tox file.
• Fix S3Transfer test missing absolute path.

Related Github Issue

Currently depends on #1283 but will be rebased.

[github-actions]

🦙 MegaLinter status: ❌ ERROR

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ PYTHON	bandit	1		0	5.11s
✅ PYTHON	black	4	0	0	1.37s
❌ PYTHON	flake8	4		9	0.73s
✅ PYTHON	isort	4	0	0	0.31s
✅ PYTHON	pylint	4		0	5.61s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.29%. Comparing base (819b6d7) to head (525a287).

Files with missing lines	Patch %	Lines
newrelic/hooks/external_botocore.py	84.61%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1300      +/-   ##
==========================================
- Coverage   81.33%   81.29%   -0.04%     
==========================================
  Files         203      203              
  Lines       22465    22485      +20     
  Branches     3562     3565       +3     
==========================================
+ Hits        18271    18280       +9     
- Misses       3012     3019       +7     
- Partials     1182     1186       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hmstepanek]

Other than removing the message traces it looks good.

[hmstepanek]

The firehose looks good. It looks like I didn't handle those cases where the ARN can be either the data stream or the consumer. You don't have to add that here but I think we should do that. I'll leave that up to you as to when we do that (either here or in a follow up)-but in those cases where it's either-or we still need to call extract function(s)-perhaps different extract functions.

[TimPansino]

The firehose looks good. It looks like I didn't handle those cases where the ARN can be either the data stream or the consumer. You don't have to add that here but I think we should do that. I'll leave that up to you as to when we do that (either here or in a follow up)-but in those cases where it's either-or we still need to call extract function(s)-perhaps different extract functions.

Let's expand on that in a follow up, so we can get the vast majority of cases covered and have it ready for demoing.