Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport NR-234826 #335

Open
wants to merge 9 commits into
base: staging
Choose a base branch
from
Open

Backport NR-234826 #335

wants to merge 9 commits into from

Conversation

cdillard-NewRelic
Copy link
Member

No description provided.

smalsam-newr
smalsam-newr approved these changes Jan 17, 2025
View reviewed changes
Agent/Instrumentation/NSURLSession/NRMAURLSessionTaskOverride.m Outdated
NSData *data = NRMA__getDataForSessionTask(task);
NRMA__recordTask(task, data, task.response, task.error);
}
task.state == NSURLSessionTaskStateRunning) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check that the response we get is of type NSHTTPURLResponse? That is kind of what the response code check does.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the other places we call NRMA__recordTask we don’t even care about the responseCode. I’m not sure why the NRMAURLSessionTaskOverride was checking the response code and checking that task.response was of type NSHTTPURLResponse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbruin-NR mbruin-NR mbruin-NR approved these changes

@smalsam-newr smalsam-newr smalsam-newr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdillard-NewRelic @smalsam-newr @mbruin-NR