Remove DISCRETE. #3167
Merged
Remove DISCRETE. #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason to remove it now is to make it easier for NMODL to pass all NRN unit-tests. Naturally, that's a problem that can be fixed differently. |
|
|
I'm ok with this . |
|
✔️ 94c7a68 -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3167 +/- ##
==========================================
- Coverage 67.11% 67.06% -0.06%
==========================================
Files 571 571
Lines 111318 111318
==========================================
- Hits 74714 74655 -59
- Misses 36604 36663 +59 ☔ View full report in Codecov by Sentry. |
JCGoran
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposal is to stop supporting DISCRETE. I can't find any usages in ModelDB. Technically, the current implementation has a couple of weaknesses, e.g. #3082 and also the fact that even or
@1it makes the mod file not thread-safe. Overall, it might be better to remove the feature. If in the future someone needs the feature, the task will be to implement it instead of debugging the existing version.