Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Benchmark Report Generation and Update Backend Configurations #33

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

markurtz
Copy link
Member

@markurtz markurtz commented Aug 27, 2024

Summary

This PR refactors the benchmark report generation process and updates backend configurations for better performance and clarity. The main changes include restructuring the entry point for benchmark generation, consolidating backend configurations, and improving error handling for better user experience.

Details

  • Introduced generate_benchmark_report_cli as the main CLI entry point for benchmark generation.
  • Refactored generate_benchmark_report to handle various input configurations and streamline the execution process.
  • Removed unused parameters (host, port) and consolidated backend URL configurations into a single target parameter.
  • Updated OpenAIBackend initialization to eliminate ambiguity around base URL settings.
  • Enhanced error handling and logging, ensuring informative messages for missing or incorrect configurations.
  • Modified EmulatedRequestGenerator and FileRequestGenerator to handle optional configuration inputs.
  • Removed obsolete CLI test files and restructured e2e tests to align with the new CLI entry point.
  • Added comprehensive unit tests for the main benchmark generation functions and CLI commands.

@markurtz markurtz self-assigned this Aug 27, 2024
@markurtz markurtz changed the title Minor fixes for current main state for first release and e2e + integration test stubs Refactor Benchmark Report Generation and Update Backend Configurations Aug 27, 2024
@markurtz markurtz merged commit 7f39986 into main Aug 27, 2024
9 checks passed
@markurtz markurtz deleted the main-tests-fixes branch August 27, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant