feat: pass context to get tracker fn as second arg #2177
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
I tried to make "dynamic" tracking with nestjs metadata for multiple scenarios. For example by default I want tracker to be
req.ip
value, but in some cases I want it to get the value fromreq.body.username
. For a temporary solution I find that creating individual guards for each scenario, but if I have access toExecutionContext
I can get "key" from the metadata. Something like this:Issue Number: N/A
What is the new behavior?
Passes
ExecutionContext
togetTracker
method as second argument. First time contributing to be honest, I hesitated to replace first paramreq
tocontext
.Does this PR introduce a breaking change?
Other information
As I said it's my first time contributing hope you understand. Also not sure if it's a breaking change