Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

Fix/dev utils certs #289

Merged
merged 9 commits into from
Nov 7, 2022
Merged

Fix/dev utils certs #289

merged 9 commits into from
Nov 7, 2022

Conversation

norling
Copy link
Contributor

@norling norling commented Nov 2, 2022

Updates the dev environment with a dedicated service for certificate handling, as well as updating some versions.

Edit: This ended up with rewriting the way tests are run to make them work with the new way certificates are handled... now you can run tests with:

docker compose run tests

and

docker compose run integration_tests

.

@norling norling requested a review from a team November 2, 2022 15:34
@norling norling force-pushed the fix/dev-utils-certs branch 5 times, most recently from ec6b8a8 to e532143 Compare November 3, 2022 09:55
@codecov-commenter
Copy link

Codecov Report

Merging #289 (e532143) into master (0686961) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #289   +/-   ##
=======================================
  Coverage   72.83%   72.83%           
=======================================
  Files           7        7           
  Lines         924      924           
=======================================
  Hits          673      673           
  Misses        209      209           
  Partials       42       42           
Flag Coverage Δ
unittests 72.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@norling norling force-pushed the fix/dev-utils-certs branch 2 times, most recently from ff99c35 to f893382 Compare November 3, 2022 11:05
@norling norling marked this pull request as ready for review November 3, 2022 11:05
@norling norling requested a review from jbygdell November 4, 2022 10:53
aaperis
aaperis previously approved these changes Nov 4, 2022
Copy link
Contributor

@aaperis aaperis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you like, consider adding the testing compose commands to the dev_utils readme for completeness, but otherwise it looks good to me :-)

jbygdell
jbygdell previously approved these changes Nov 4, 2022
@norling norling force-pushed the fix/dev-utils-certs branch from f7b7c5d to 176c1b5 Compare November 7, 2022 08:21
@aaperis aaperis self-requested a review November 7, 2022 08:33
Copy link
Contributor

@aaperis aaperis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great :-)

@norling norling merged commit ab504cb into master Nov 7, 2022
@norling norling deleted the fix/dev-utils-certs branch November 7, 2022 08:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants