This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec6b8a8
to
e532143
Compare
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
=======================================
Coverage 72.83% 72.83%
=======================================
Files 7 7
Lines 924 924
=======================================
Hits 673 673
Misses 209 209
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ff99c35
to
f893382
Compare
jbygdell
suggested changes
Nov 3, 2022
aaperis
previously approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you like, consider adding the testing compose commands to the dev_utils readme for completeness, but otherwise it looks good to me :-)
jbygdell
previously approved these changes
Nov 4, 2022
d58ee62
to
f7b7c5d
Compare
f7b7c5d
to
156536f
Compare
156536f
to
f7b7c5d
Compare
This makes the tests able to run outside of the compose setup
Skip the test step if the compose certs are missing
f7b7c5d
to
176c1b5
Compare
aaperis
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great :-)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the dev environment with a dedicated service for certificate handling, as well as updating some versions.
Edit: This ended up with rewriting the way tests are run to make them work with the new way certificates are handled... now you can run tests with:
and
.