linter suggestions

helper/helper.go

@@ -348,11 +348,9 @@ func TLSkeyToFile(filename string, key *ecdsa.PrivateKey) error {
 	if err != nil {
 		return err
 	}
-	if err := pem.Encode(keyFile, &pem.Block{Type: "EC PRIVATE KEY", Bytes: pk}); err != nil {
-		return err
-	}
+	err = pem.Encode(keyFile, &pem.Block{Type: "EC PRIVATE KEY", Bytes: pk})
 
-	return nil
+	return err
 }
 
 func TLScertToFile(filename string, derBytes []byte) error {
@@ -361,9 +359,7 @@ func TLScertToFile(filename string, derBytes []byte) error {
 		return err
 	}
 	defer certFile.Close()
-	if err := pem.Encode(certFile, &pem.Block{Type: "CERTIFICATE", Bytes: derBytes}); err != nil {
-		return err
-	}
+	err = pem.Encode(certFile, &pem.Block{Type: "CERTIFICATE", Bytes: derBytes})
 
-	return nil
+	return err
 }

proxy.go

@@ -82,12 +82,12 @@ func (p *Proxy) internalServerError(w http.ResponseWriter, r *http.Request) {
 	w.WriteHeader(500)
 }
 
-func (p *Proxy) notAllowedResponse(w http.ResponseWriter, r *http.Request) {
+func (p *Proxy) notAllowedResponse(w http.ResponseWriter, _ *http.Request) {
 	log.Debug("not allowed response")
 	w.WriteHeader(403)
 }
 
-func (p *Proxy) notAuthorized(w http.ResponseWriter, r *http.Request) {
+func (p *Proxy) notAuthorized(w http.ResponseWriter, _ *http.Request) {
 	log.Debug("not authorized")
 	w.WriteHeader(401) // Actually correct!
 }

proxy_test.go

@@ -139,7 +139,7 @@ func (m *MockMessenger) SendMessage(uuid string, body []byte) error {
 type AlwaysDeny struct{}
 
 // Authenticate does not authenticate anyone.
-func (u *AlwaysDeny) Authenticate(r *http.Request) (jwt.MapClaims, error) {
+func (u *AlwaysDeny) Authenticate(_ *http.Request) (jwt.MapClaims, error) {
 	return nil, fmt.Errorf("denied")
 }
 

userauth.go

@@ -34,7 +34,7 @@ func NewAlwaysAllow() *AlwaysAllow {
 }
 
 // Authenticate authenticates everyone.
-func (u *AlwaysAllow) Authenticate(r *http.Request) (jwt.MapClaims, error) {
+func (u *AlwaysAllow) Authenticate(_ *http.Request) (jwt.MapClaims, error) {
 	return nil, nil
 }