feat(optimistic_block): pass optimistic block to producers over T1 #12888
+143
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Longarithm
reviewed
Feb 7, 2025
Comment on lines
+787
to
+788
| // TODO(#10584): send this message to all the producers. | ||
| // Maybe we just need to send this to the next producers. |
There was a problem hiding this comment.
Isn't tier1 the same as "all validators"? Yeah we need to send it to all chunk producers in this epoch.
There was a problem hiding this comment.
The question here was between thw whole of T1 or just next N blocks worth of producers. 99 vs 8(shards) * N(blocks). But we can go with all for now.
VanBarbascu
force-pushed
the
optimistic_block/send
branch
from
afaab02 to
c0696ac
Compare
VanBarbascu
force-pushed
the
optimistic_block/send
branch
from
c0696ac to
3c20bb6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12888 +/- ##
==========================================
- Coverage 70.54% 70.53% -0.02%
==========================================
Files 851 851
Lines 174914 174983 +69
Branches 174914 174983 +69
==========================================
+ Hits 123395 123424 +29
- Misses 46397 46430 +33
- Partials 5122 5129 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Longarithm
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the optimistic block to all producers over the T1 network.