fix: account version serialization tests #12871
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugachAG
requested changes
Feb 4, 2025
| amount: 1_000_000, | ||
| locked: 1_000_000, | ||
| code_hash: CryptoHash::hash_bytes(&[42]), | ||
| storage_usage: 100, | ||
| }; | ||
| let old_account = Account::V1(account_v1.clone()); |
There was a problem hiding this comment.
old account is expected to be just AccountV1 (not wrapped in enum) since that is the old representation
There was a problem hiding this comment.
the issue with that is that the serde / borsh traits are implemented for the Account enum. Should I also implement them for AccountV1?
There was a problem hiding this comment.
what is the exact problem you trying to solve here?
There was a problem hiding this comment.
Trying to introduce the AccountContractType enum here but the serde v1 test fails if it is not wrapped in Account
There was a problem hiding this comment.
you are not allowed to remove fields from SerdeAccount that breaks backward compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.