Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove shard functions from epoch manager #12843

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

stedfn
Copy link
Contributor

@stedfn stedfn commented Jan 30, 2025

No description provided.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 74.42922% with 56 lines in your changes missing coverage. Please review.

Project coverage is 70.38%. Comparing base (c625d98) to head (4bf634e).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
chain/epoch-manager/src/shard_tracker.rs 77.86% 6 Missing and 23 partials ⚠️
nearcore/src/entity_debug.rs 0.00% 8 Missing ⚠️
...chain/src/stateless_validation/chunk_validation.rs 50.00% 0 Missing and 4 partials ⚠️
tools/replay-archive/src/cli.rs 0.00% 4 Missing ⚠️
chain/chain/src/store/mod.rs 33.33% 0 Missing and 2 partials ⚠️
chain/chain/src/validate.rs 0.00% 0 Missing and 2 partials ⚠️
...src/stateless_validation/state_witness_producer.rs 77.77% 0 Missing and 2 partials ⚠️
tools/state-viewer/src/apply_chunk.rs 33.33% 0 Missing and 2 partials ⚠️
chain/chain/src/migrations.rs 0.00% 0 Missing and 1 partial ⚠️
chain/chunks/src/logic.rs 0.00% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12843      +/-   ##
==========================================
- Coverage   70.41%   70.38%   -0.03%     
==========================================
  Files         848      848              
  Lines      174930   174764     -166     
  Branches   174930   174764     -166     
==========================================
- Hits       123169   123006     -163     
- Misses      46506    46513       +7     
+ Partials     5255     5245      -10     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (+<0.01%) ⬆️
db-migration 0.16% <0.00%> (+<0.01%) ⬆️
genesis-check 1.41% <0.00%> (+<0.01%) ⬆️
linux 69.99% <74.42%> (-0.03%) ⬇️
linux-nightly 70.02% <74.42%> (-0.04%) ⬇️
pytests 1.71% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.53% <0.00%> (+<0.01%) ⬆️
unittests 70.21% <74.42%> (-0.03%) ⬇️
upgradability 0.20% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stedfn stedfn requested a review from pugachAG January 30, 2025 11:54
@stedfn stedfn marked this pull request as ready for review January 30, 2025 11:54
@stedfn stedfn requested a review from a team as a code owner January 30, 2025 11:54
Copy link
Contributor

@pugachAG pugachAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stedfn stedfn added this pull request to the merge queue Jan 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2025
@stedfn stedfn added this pull request to the merge queue Jan 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2025
@Longarithm Longarithm added this pull request to the merge queue Jan 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2025
@Longarithm Longarithm added this pull request to the merge queue Jan 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2025
@Longarithm Longarithm added this pull request to the merge queue Jan 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants